Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadAppinfo takes too long #4

Open
SomeoneIsWorking opened this issue Jul 1, 2019 · 1 comment
Open

LoadAppinfo takes too long #4

SomeoneIsWorking opened this issue Jul 1, 2019 · 1 comment
Assignees

Comments

@SomeoneIsWorking
Copy link

SomeoneIsWorking commented Jul 1, 2019

I've noticed plugin startup takes more than ~3200ms seconds and ran debugger from source and it halts the most on LoadAppinfo and replaced the plugin from the builds generated without LoadAppinfo and load time went down to ~200ms

Update 1: Apparently it's because of serializing/deserializing BinaryVdfItem.
I forked it and it appears only Icon is used from BinaryVdfItem so I'm going to store the used fields in a separate class and cache it instead.

Update 2: I pushed the updates to my fork, it "works", icons show up, startup time is ~400ms but I compulsively edited a lot of other parts of code and most of the changes are in a single commit so I don't know if you would want to merge it here.

@SkaceKamen
Copy link
Owner

SkaceKamen commented Jul 4, 2019

I didn't really focus on the initialize time optimizations as originally I wasn't even planning on publishing the extension :).

You can try to create a pull request and I'll try to review it.

@SkaceKamen SkaceKamen self-assigned this Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants