Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider BIP 87 for new wallets #52

Open
Sjors opened this issue May 31, 2021 · 1 comment
Open

Consider BIP 87 for new wallets #52

Sjors opened this issue May 31, 2021 · 1 comment
Assignees
@Sjors

Comments

@Sjors
Copy link
Owner

Sjors commented May 31, 2021 •
edited
Loading

We currently use m/48h/0h/2h. The new BIP 87 suggests a simpler derivation path m/87h/0h.

This requires checking:

  • if Specter supports it
  • if other hardware wallet special case m/48h/0h/2h or if they don't care
  • storing our path in Core Data, rather than hardcoding it in Signer.getSignerUs and SeedManager.ourPubKey (in order not to break existing wallets)
@Sjors Sjors self-assigned this May 31, 2021
@w-i-n-s
Copy link
Contributor

w-i-n-s commented Jul 18, 2021

@Sjors On Core Data side we can store strings or data. So, no blockers here.

@Sjors Sjors mentioned this issue Jul 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sjors Sjors

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sjors @w-i-n-s