-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not placing completed item on random unit if same item is being built on another unit #27
Comments
Currently, there is still a limitation that there are many unnecessary items on the board if a completed item has not been built yet. I think there needs to be a mechanism to check which items are completely unnecessary. Or place it randomly on champions in a specific round to avoid it taking up all the positions on the board. |
You are meaning items aren't being picked up from board because item bench is full of components that are never used by the comp? |
yes sir, actually I have added a minor function based on your code that when the health is below 35 HP, the bot will place items randomized into a champion that doesn't item at all. |
Ahh so you are currently slamming everything on champs without a build once health is below 35 Honestly I want to clean up the item placement code into separate functions because it's a nested mess that's hard to read and understand at first glance but every time I try it breaks it and I end up reverting back to the nest haha |
I think this bot is just for farming so don't need so much effort. |
Oh yeah I only use it to farm but I'd also like to read it the item placement code without having to re-read it 10 times to understand one small section even with the comments I have left for myself |
Also I'll work on this during my weekend and add the below 35 item slamming too |
Glad to hear that. So I don't need to update the code myself again hehe. |
Haha sure your code is better than mine |
So just an update for you. I'm using the item placement logic from AntonSax's bot in my current build though I have had to change things so it actually works... Mainly adding the correct number for item slots once a item is added to a champ. I also added logic for Tacticians Crown and all the Glove items since it wasn't there I need to do more testing and remove all the printing of useless spam information so I'm hoping I'll have it done by tomorrow at some point |
@kizxlove so I've made a branch for new item placement |
I will try it asap. Haha |
I've made changes to when secondary items are placed on champs previously one of the conditions was placing when item bench was full of items (10 items) now I've changed this to 6 or more items that way we don't have item orbs on our board like before. Also added logic for magnetic remover to add a item to a champ then use the remover on that champ that way we don't have them taking up item spaces. Reforger also does with but only if we have more than 2 of the same item so if we have 3 tears it will place a tear on a champ and use reforger on that champ Still testing remover and reforger... Somehow haven't got these items since updating the logic lol |
it may be because these items don't have data in the original code. |
I've made a few changes... Mostly getting gloves to work correctly since it was still trying to add gloves to champs with items but still not sure if the new code has fixed that but I'll push changes anyway since it has the working remover and reforger code... I also haven't came across anything that has crashed the bot so I think it's fine to push update to the branch |
Ahri building BlueBuff has TearoftheGoddess on unit and if BlueBuff is on item bench it won't put BlueBuff on random unit until TearoftheGoddess is completed on Ahri
Also sometimes puts a random item on a champion with a predefined build... Eg randomly putting EvenShroud on Samira as last item instead of GiantSlayer
The text was updated successfully, but these errors were encountered: