Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not placing completed item on random unit if same item is being built on another unit #27

Open
Sizzzles opened this issue Dec 27, 2023 · 15 comments
Labels
bug Something isn't working

Comments

@Sizzzles
Copy link
Owner

Ahri building BlueBuff has TearoftheGoddess on unit and if BlueBuff is on item bench it won't put BlueBuff on random unit until TearoftheGoddess is completed on Ahri

Also sometimes puts a random item on a champion with a predefined build... Eg randomly putting EvenShroud on Samira as last item instead of GiantSlayer

@Sizzzles Sizzzles added the bug Something isn't working label Dec 27, 2023
@kizxlove
Copy link

Currently, there is still a limitation that there are many unnecessary items on the board if a completed item has not been built yet. I think there needs to be a mechanism to check which items are completely unnecessary. Or place it randomly on champions in a specific round to avoid it taking up all the positions on the board.

@Sizzzles
Copy link
Owner Author

You are meaning items aren't being picked up from board because item bench is full of components that are never used by the comp?
So something like if component items not in comp build list then throw away component items on random champ to make space on item bench?

@kizxlove
Copy link

You are meaning items aren't being picked up from board because item bench is full of components that are never used by the comp? So something like if component items not in comp build list then throw away component items on random champ to make space on item bench?

yes sir, actually I have added a minor function based on your code that when the health is below 35 HP, the bot will place items randomized into a champion that doesn't item at all.

@Sizzzles
Copy link
Owner Author

Ahh so you are currently slamming everything on champs without a build once health is below 35

Honestly I want to clean up the item placement code into separate functions because it's a nested mess that's hard to read and understand at first glance but every time I try it breaks it and I end up reverting back to the nest haha

@kizxlove
Copy link

Ahh so you are currently slamming everything on champs without a build once health is below 35

Honestly I want to clean up the item placement code into separate functions because it's a nested mess that's hard to read and understand at first glance but every time I try it breaks it and I end up reverting back to the nest haha

I think this bot is just for farming so don't need so much effort.

@Sizzzles
Copy link
Owner Author

Oh yeah I only use it to farm but I'd also like to read it the item placement code without having to re-read it 10 times to understand one small section even with the comments I have left for myself

@Sizzzles
Copy link
Owner Author

You are meaning items aren't being picked up from board because item bench is full of components that are never used by the comp? So something like if component items not in comp build list then throw away component items on random champ to make space on item bench?

Also I'll work on this during my weekend and add the below 35 item slamming too

@kizxlove
Copy link

You are meaning items aren't being picked up from board because item bench is full of components that are never used by the comp? So something like if component items not in comp build list then throw away component items on random champ to make space on item bench?

Also I'll work on this during my weekend and add the below 35 item slamming too

Glad to hear that. So I don't need to update the code myself again hehe.

@Sizzzles
Copy link
Owner Author

Haha sure your code is better than mine

@Sizzzles
Copy link
Owner Author

So just an update for you. I'm using the item placement logic from AntonSax's bot in my current build though I have had to change things so it actually works... Mainly adding the correct number for item slots once a item is added to a champ.

I also added logic for Tacticians Crown and all the Glove items since it wasn't there
Champs also have recommended items now which we are getting from the deck.json. If we can build recommended items on our champs in the comp it will.
We are also slamming items below 35 health

I need to do more testing and remove all the printing of useless spam information so I'm hoping I'll have it done by tomorrow at some point

@Sizzzles
Copy link
Owner Author

@kizxlove so I've made a branch for new item placement
This is just so I don't overwrite the live version of this bot if this item placement sucks haha

@kizxlove
Copy link

I will try it asap. Haha

@Sizzzles
Copy link
Owner Author

I've made changes to when secondary items are placed on champs previously one of the conditions was placing when item bench was full of items (10 items) now I've changed this to 6 or more items that way we don't have item orbs on our board like before.

Also added logic for magnetic remover to add a item to a champ then use the remover on that champ that way we don't have them taking up item spaces. Reforger also does with but only if we have more than 2 of the same item so if we have 3 tears it will place a tear on a champ and use reforger on that champ

Still testing remover and reforger... Somehow haven't got these items since updating the logic lol

@kizxlove
Copy link

it may be because these items don't have data in the original code.
In addition, RITO just updated the vanguard, so I think that we might test this code in clone account to ensure that it's still safe enough for farming tokens.

@Sizzzles
Copy link
Owner Author

I've made a few changes... Mostly getting gloves to work correctly since it was still trying to add gloves to champs with items but still not sure if the new code has fixed that but I'll push changes anyway since it has the working remover and reforger code... I also haven't came across anything that has crashed the bot so I think it's fine to push update to the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants