Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
|
kode udah rapih, readme juga udah okee, paling minor feedback pas buat tag release jelasin apa aja yang udah dibuat dll. keep up the goodwork |
Co-authored-by: Rava Maulana <[email protected]> Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: razzanYoni <[email protected]>
Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: Rava Maulana <[email protected]>
Lock1
reviewed
Mar 20, 2023
src/filesystem/fat32.c
Outdated
| uint32_t cluster_to_lba(uint32_t cluster){ | ||
| // dr nanobyte -> lba = data_region_begin + (cluster-2)*sector_per_cluster | ||
| return (cluster-2) * cluster_size; // ? |
There was a problem hiding this comment.
On extra sidenote: Untuk tugas besar ini lebih straightforward lagi Cluster to LBA-nya, no offset, no anything, cluster 0 berada di block 0, cluster 1 di block 4, and so on
Lock1
reviewed
Mar 20, 2023
src/interrupt/interrupt.c
Outdated
| @@ -1,5 +1,7 @@ | |||
| #include "../lib-header/interrupt.h" | |||
|
|
|||
| #define IRQ1 33 | |||
There was a problem hiding this comment.
Some fun fact: PIC Remap yang menggeser master ke 0x20, membuat juga semua IRQ tergeser ke sana (IRQ0 -> 0x20, IRQ1 -> 0x21 = 33, ...), jadi bisa juga PIC1_OFFSET + IRQ_KEYBOARD
Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: Rava Maulana <[email protected]>
Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: Rava Maulana <[email protected]>
Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Rava Maulana <[email protected]> Co-authored-by: Nigel Sahl <[email protected]>
Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Rava Maulana <[email protected]>
Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Rava Maulana <[email protected]> Co-authored-by: Nigel Sahl <[email protected]>
Co-authored-by: Nigel Sahl <[email protected]>
Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: Rava Maulana <[email protected]>
Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: Rava Maulana <[email protected]>
Co-authored-by: Rava Maulana <[email protected]> Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Nigel Sahl <[email protected]>
Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Rava Maulana <[email protected]>
Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Rava Maulana <[email protected]>
Co-authored-by: Rava Maulana <[email protected]> Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: razzanYoni <[email protected]>
Fix/revert 3.2
Co-authored-by: Rava Maulana <[email protected]> Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Nigel Sahl <[email protected]>
Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Rava Maulana <[email protected]> Co-authored-by: Nigel Sahl <[email protected]>
Co-authored-by: razzanYoni <[email protected]> Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: Rava Maulana <[email protected]>
Co-authored-by: Rava Maulana <[email protected]> Co-authored-by: Nigel Sahl <[email protected]>
Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: razzanYoni <[email protected]> Co-authored-by: RMA1403 <[email protected]>
Feat/whereis
Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: razzanYoni <[email protected]> Co-authored-by: RMA1403 <[email protected]>
Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: razzanYoni <[email protected]> Co-authored-by: RMA1403 <[email protected]>
Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: razzanYoni <[email protected]> Co-authored-by: RMA1403 <[email protected]>
Co-authored-by: Nigel Sahl <[email protected]> Co-authored-by: razzanYoni <[email protected]> Co-authored-by: RMA1403 <[email protected]>
|
Aekwaoewakoewaewakoe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @hanifmz07 @NerbFox @razzanYoni @RMA1403