Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling system doesn't work properly #1231

Open
RedBurningPhoenix opened this issue Nov 16, 2024 · 4 comments
Open

Pulling system doesn't work properly #1231

RedBurningPhoenix opened this issue Nov 16, 2024 · 4 comments
Labels
Type: Bug [Un]intentional issue with something

Comments

@RedBurningPhoenix
Copy link

Description

The latest PullingSystem updates are working in a very odd way. In admin ghost it is impossible to push any items normally.
Any push of glass shards/knife and etc for throws work strangely. Sometimes pulling stop works properly.
Also, it looks very twitchy.

Reproduction

  1. Get glass Shards or other entities with Throwing
  2. Start pushing towards Any entity with collision by PMB

Expected behavior

  1. Nothing, it just can't hit anything with that speed

Media

Desktop.2024.04.25.-.23.28.28.06.DVR_1.mp4
@RedBurningPhoenix RedBurningPhoenix added the Type: Bug [Un]intentional issue with something label Nov 16, 2024
@VMSolidus
Copy link
Member

This is TECHNICALLY Not a bug. The pulling system was reworked so that Pushing objects involves the same interaction as Pulling objects, so that SMOL characters can't cheat their pulling disadvantage by pushing instead. Admin Ghosts are massless, so they essentially can't push objects. If you want to "Fix" this, give them a stupidly massive fixture so that they can push whatever they want.

@RedBurningPhoenix
Copy link
Author

This is TECHNICALLY Not a bug. The pulling system was reworked so that Pushing objects involves the same interaction as Pulling objects, so that SMOL characters can't cheat their pulling disadvantage by pushing instead. Admin Ghosts are massless, so they essentially can't push objects. If you want to "Fix" this, give them a stupidly massive fixture so that they can push whatever they want.

Not only that, at the 26th second the shard stays in place, despite the fact that it is in the character's hands and he is dragging it.
I've encountered this bug exactly 2 times and I couldn't even reproduce it.
Other people tell me about the "telekinesis" of the throw away objects, so far I have not been given confirmation of this.

@VMSolidus
Copy link
Member

This is TECHNICALLY Not a bug. The pulling system was reworked so that Pushing objects involves the same interaction as Pulling objects, so that SMOL characters can't cheat their pulling disadvantage by pushing instead. Admin Ghosts are massless, so they essentially can't push objects. If you want to "Fix" this, give them a stupidly massive fixture so that they can push whatever they want.

Not only that, at the 26th second the shard stays in place, despite the fact that it is in the character's hands and he is dragging it. I've encountered this bug exactly 2 times and I couldn't even reproduce it. Other people tell me about the "telekinesis" of the throw away objects, so far I have not been given confirmation of this.

That's not a bug either, the glass shard got embedded in the Urist, attaching it to him. Glass shards are coded to collide with players and embed in them(hence the doafter to remove it). They also deal damage to a person when doing this.

@Mnemotechnician
Copy link
Contributor

Mnemotechnician commented Nov 16, 2024

This is TECHNICALLY Not a bug.

It is a bug. It is something i was intending to fix before marking the pulling rework as "ready for review", but apparently forgot to do...

Also, glass shards are not supposed to embed into entities while being in the OnGround state, that is also a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug [Un]intentional issue with something
Projects
None yet
Development

No branches or pull requests

3 participants