Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add a packet format in network module #42

Open
SettingDust opened this issue Oct 21, 2022 · 3 comments
Open

[Proposal] Add a packet format in network module #42

SettingDust opened this issue Oct 21, 2022 · 3 comments

Comments

@SettingDust
Copy link

Add a packet serial format to network module and use it instead of cbor.
And maybe the network should register channel standalone instead of "subchannel" of silk

@jakobkmar
Copy link
Member

I am not against this, but before starting to implement this, could you list the benefits of this over Cbor.

@SettingDust
Copy link
Author

I am not against this, but before starting to implement this, could you list the benefits of this over Cbor.

Parse packet from other mod or lib.

@jakobkmar
Copy link
Member

I guess we could add a quick implementation (requiring opt-in) which uses the Silk nbt serialization and then writes the nbt to the packet (mojang already has a translation there) until we implement serialization to PacketByteBufs directly and make the API stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants