From f6add7fc48ff1aae87be18b29b208ed7c7c8a5f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Pouiller?= Date: Wed, 11 Dec 2024 15:15:13 +0100 Subject: [PATCH 1/4] github: workflows: Add test for offloaded sockets MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Offloaded sockets can be easily broken. This patch ensures it won't happen. Signed-off-by: Jérôme Pouiller --- .github/workflows/build.yml | 2 ++ .github/workflows/upstream-build.yml | 2 ++ samples/net/wifi/shell/soc/siwx917_offloaded_sockets.conf | 1 + 3 files changed, 5 insertions(+) create mode 100644 samples/net/wifi/shell/soc/siwx917_offloaded_sockets.conf diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7ce8da0..67714f4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -76,3 +76,5 @@ jobs: shell: bash run: | west twister -s sample.net.wifi -p siwx917_rb4338a -v --inline-logs -K + west twister -s sample.net.wifi -p siwx917_rb4338a -v --inline-logs -K \ + -x EXTRA_CONF_FILE=$(pwd)/samples/net/wifi/shell/soc/siwx917_offloaded_sockets.conf diff --git a/.github/workflows/upstream-build.yml b/.github/workflows/upstream-build.yml index 1f357bf..6879f1c 100644 --- a/.github/workflows/upstream-build.yml +++ b/.github/workflows/upstream-build.yml @@ -82,3 +82,5 @@ jobs: shell: bash run: | west twister -s sample.net.wifi -p siwx917_rb4338a -v --inline-logs -K + west twister -s sample.net.wifi -p siwx917_rb4338a -v --inline-logs -K \ + -x EXTRA_CONF_FILE=$(pwd)/samples/net/wifi/shell/soc/siwx917_offloaded_sockets.conf diff --git a/samples/net/wifi/shell/soc/siwx917_offloaded_sockets.conf b/samples/net/wifi/shell/soc/siwx917_offloaded_sockets.conf new file mode 100644 index 0000000..4d2a10a --- /dev/null +++ b/samples/net/wifi/shell/soc/siwx917_offloaded_sockets.conf @@ -0,0 +1 @@ +CONFIG_WIFI_SIWX917_NET_STACK_OFFLOAD=y From aa0b348c23ed4bcaf2f75044247c7cf7605689d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Pouiller?= Date: Sat, 21 Dec 2024 11:51:41 +0100 Subject: [PATCH 2/4] github: workflows: Fix long line MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Just cut long line. Signed-off-by: Jérôme Pouiller --- .github/workflows/build.yml | 3 ++- .github/workflows/upstream-build.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 67714f4..fddf534 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -48,7 +48,8 @@ jobs: working-directory: zephyr-silabs shell: bash run: | - west twister -s drivers.flash.common.default -p siwx917_rb4338a -x DTC_OVERLAY_FILE=$(pwd)/tests/drivers/flash/common/boards/siwx917_rb4338a.overlay -v --inline-logs + west twister -s drivers.flash.common.default -p siwx917_rb4338a -v --inline-logs \ + -x DTC_OVERLAY_FILE=$(pwd)/tests/drivers/flash/common/boards/siwx917_rb4338a.overlay - name: Build DMA test working-directory: zephyr-silabs diff --git a/.github/workflows/upstream-build.yml b/.github/workflows/upstream-build.yml index 6879f1c..bf56a57 100644 --- a/.github/workflows/upstream-build.yml +++ b/.github/workflows/upstream-build.yml @@ -50,7 +50,8 @@ jobs: working-directory: zephyr-silabs shell: bash run: | - west twister -s drivers.flash.common.default -p siwx917_rb4338a -x DTC_OVERLAY_FILE=$(pwd)/tests/drivers/flash/common/boards/siwx917_rb4338a.overlay -v --inline-logs + west twister -s drivers.flash.common.default -p siwx917_rb4338a -v --inline-logs \ + -x DTC_OVERLAY_FILE=$(pwd)/tests/drivers/flash/common/boards/siwx917_rb4338a.overlay - name: Build DMA test working-directory: zephyr-silabs From cab24e8a64464bb0b88a8dc5376d8a91f460d72e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Pouiller?= Date: Sat, 21 Dec 2024 11:54:11 +0100 Subject: [PATCH 3/4] github: workflows: Fix DMA test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently, the variable "TC_OVERLAY_FILE" was used instead of "DTC_OVERLAY_FILE" and options "-v" and "--inline-logs" were passed to "west build" instead of twister. In addition, the other test use "-x" rather than "--" to pass option to "west build" Signed-off-by: Jérôme Pouiller --- .github/workflows/build.yml | 7 +++---- .github/workflows/upstream-build.yml | 7 +++---- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fddf534..9a0ede1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -55,10 +55,9 @@ jobs: working-directory: zephyr-silabs shell: bash run: | - west twister -s drivers.dma.chan_blen_transfer -p siwx917_rb4338a -- \ - -DTC_OVERLAY_FILE=$(pwd)/tests/drivers/dma/chan_blen_transfer/boards/siwx917_rb4338a.overlay \ - -DEXTRA_CONF_FILE=$(pwd)/tests/drivers/dma/chan_blen_transfer/boards/siwx917_rb4338a.conf \ - -v --inline-logs + west twister -s drivers.dma.chan_blen_transfer -p siwx917_rb4338a -v --inline-logs \ + -x DTC_OVERLAY_FILE=$(pwd)/tests/drivers/dma/chan_blen_transfer/boards/siwx917_rb4338a.overlay \ + -x EXTRA_CONF_FILE=$(pwd)/tests/drivers/dma/chan_blen_transfer/boards/siwx917_rb4338a.conf - name: Build Bluetooth samples working-directory: zephyr-silabs diff --git a/.github/workflows/upstream-build.yml b/.github/workflows/upstream-build.yml index bf56a57..556a684 100644 --- a/.github/workflows/upstream-build.yml +++ b/.github/workflows/upstream-build.yml @@ -57,10 +57,9 @@ jobs: working-directory: zephyr-silabs shell: bash run: | - west twister -s drivers.dma.chan_blen_transfer -p siwx917_rb4338a -- \ - -DTC_OVERLAY_FILE=$(pwd)/tests/drivers/dma/chan_blen_transfer/boards/siwx917_rb4338a.overlay \ - -DEXTRA_CONF_FILE=$(pwd)/tests/drivers/dma/chan_blen_transfer/boards/siwx917_rb4338a.conf \ - -v --inline-logs + west twister -s drivers.dma.chan_blen_transfer -p siwx917_rb4338a -v --inline-logs \ + -x DTC_OVERLAY_FILE=$(pwd)/tests/drivers/dma/chan_blen_transfer/boards/siwx917_rb4338a.overlay \ + -x EXTRA_CONF_FILE=$(pwd)/tests/drivers/dma/chan_blen_transfer/boards/siwx917_rb4338a.conf - name: Build Bluetooth samples working-directory: zephyr-silabs From a063c5b275a515f9516b68c530f5c13481539366 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Pouiller?= Date: Sat, 21 Dec 2024 12:04:58 +0100 Subject: [PATCH 4/4] github: workflows: Break twister lines MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is yet another cosmetic change. The idea is to make the tests easier to read by placing each test and each platform on one line. Signed-off-by: Jérôme Pouiller --- .github/workflows/build.yml | 31 ++++++++++++++++++-------- .github/workflows/upstream-build.yml | 33 ++++++++++++++++++---------- 2 files changed, 44 insertions(+), 20 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 9a0ede1..0382983 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -42,20 +42,26 @@ jobs: working-directory: zephyr-silabs shell: bash run: | - west twister -s drivers.entropy -p siwx917_rb4338a -v --inline-logs + west twister -v --inline-logs \ + -s drivers.entropy \ + -p siwx917_rb4338a - name: Build Flash test working-directory: zephyr-silabs shell: bash run: | - west twister -s drivers.flash.common.default -p siwx917_rb4338a -v --inline-logs \ - -x DTC_OVERLAY_FILE=$(pwd)/tests/drivers/flash/common/boards/siwx917_rb4338a.overlay + west twister -v --inline-logs \ + -s drivers.flash.common.default \ + -p siwx917_rb4338a \ + -x DTC_OVERLAY_FILE=$(pwd)/tests/drivers/flash/common/boards/siwx917_rb4338a.overlay - name: Build DMA test working-directory: zephyr-silabs shell: bash run: | - west twister -s drivers.dma.chan_blen_transfer -p siwx917_rb4338a -v --inline-logs \ + west twister -v --inline-logs \ + -s drivers.dma.chan_blen_transfer \ + -p siwx917_rb4338a \ -x DTC_OVERLAY_FILE=$(pwd)/tests/drivers/dma/chan_blen_transfer/boards/siwx917_rb4338a.overlay \ -x EXTRA_CONF_FILE=$(pwd)/tests/drivers/dma/chan_blen_transfer/boards/siwx917_rb4338a.conf @@ -63,18 +69,25 @@ jobs: working-directory: zephyr-silabs shell: bash run: | - west twister -s sample.bluetooth.peripheral_hr -p siwx917_rb4338a -v --inline-logs -K + west twister -v --inline-logs -K \ + -s sample.bluetooth.peripheral_hr \ + -p siwx917_rb4338a - name: Build Rail samples working-directory: zephyr-silabs shell: bash run: | - west twister -s sample.rail.simple_txrx -T samples -v --inline-logs + west twister -v --inline-logs \ + -s sample.rail.simple_txrx -T samples - name: Build Wifi samples working-directory: zephyr-silabs shell: bash run: | - west twister -s sample.net.wifi -p siwx917_rb4338a -v --inline-logs -K - west twister -s sample.net.wifi -p siwx917_rb4338a -v --inline-logs -K \ - -x EXTRA_CONF_FILE=$(pwd)/samples/net/wifi/shell/soc/siwx917_offloaded_sockets.conf + west twister -v --inline-logs -K \ + -s sample.net.wifi \ + -p siwx917_rb4338a + west twister -v --inline-logs -K \ + -s sample.net.wifi \ + -p siwx917_rb4338a \ + -x EXTRA_CONF_FILE=$(pwd)/samples/net/wifi/shell/soc/siwx917_offloaded_sockets.conf diff --git a/.github/workflows/upstream-build.yml b/.github/workflows/upstream-build.yml index 556a684..d9c9b88 100644 --- a/.github/workflows/upstream-build.yml +++ b/.github/workflows/upstream-build.yml @@ -44,20 +44,26 @@ jobs: working-directory: zephyr-silabs shell: bash run: | - west twister -s drivers.entropy -p siwx917_rb4338a -v --inline-logs -K + west twister -v --inline-logs -K \ + -s drivers.entropy \ + -p siwx917_rb4338a - name: Build Flash test working-directory: zephyr-silabs shell: bash run: | - west twister -s drivers.flash.common.default -p siwx917_rb4338a -v --inline-logs \ - -x DTC_OVERLAY_FILE=$(pwd)/tests/drivers/flash/common/boards/siwx917_rb4338a.overlay + west twister -v --inline-logs \ + -s drivers.flash.common.default \ + -p siwx917_rb4338a \ + -x DTC_OVERLAY_FILE=$(pwd)/tests/drivers/flash/common/boards/siwx917_rb4338a.overlay - name: Build DMA test working-directory: zephyr-silabs shell: bash run: | - west twister -s drivers.dma.chan_blen_transfer -p siwx917_rb4338a -v --inline-logs \ + west twister -v --inline-logs \ + -s drivers.dma.chan_blen_transfer \ + -p siwx917_rb4338a \ -x DTC_OVERLAY_FILE=$(pwd)/tests/drivers/dma/chan_blen_transfer/boards/siwx917_rb4338a.overlay \ -x EXTRA_CONF_FILE=$(pwd)/tests/drivers/dma/chan_blen_transfer/boards/siwx917_rb4338a.conf @@ -66,21 +72,26 @@ jobs: shell: bash run: | west twister -v --inline-logs -K \ - -p xg27_dk2602a \ - -p siwx917_rb4338a \ -s sample.bluetooth.peripheral_hr \ - -s sample.bluetooth.observer + -s sample.bluetooth.observer \ + -p xg27_dk2602a \ + -p siwx917_rb4338a - name: Build Rail samples working-directory: zephyr-silabs shell: bash run: | - west twister -s sample.rail.simple_txrx -T samples -v --inline-logs + west twister -v --inline-logs \ + -s sample.rail.simple_txrx -T samples - name: Build Wifi samples working-directory: zephyr-silabs shell: bash run: | - west twister -s sample.net.wifi -p siwx917_rb4338a -v --inline-logs -K - west twister -s sample.net.wifi -p siwx917_rb4338a -v --inline-logs -K \ - -x EXTRA_CONF_FILE=$(pwd)/samples/net/wifi/shell/soc/siwx917_offloaded_sockets.conf + west twister -v --inline-logs -K \ + -s sample.net.wifi \ + -p siwx917_rb4338a + west twister -v --inline-logs -K \ + -s sample.net.wifi \ + -p siwx917_rb4338a \ + -x EXTRA_CONF_FILE=$(pwd)/samples/net/wifi/shell/soc/siwx917_offloaded_sockets.conf