From 6b37cc9f7dd5c07d8ff30a927c856b8046d688fc Mon Sep 17 00:00:00 2001 From: shgutte <102281713+shgutte@users.noreply.github.com> Date: Fri, 22 Nov 2024 09:21:37 +0530 Subject: [PATCH] [Silabs] Adds changes for min and max values of refrigerator temperature controlled cabinet (#36592) * Adds changes for min and max values of refrigerator temperature control cabinet * Removed the manual set for temperatureset-point * Converting Fahrenheit to Celsius min max values --- .../silabs/data_model/refrigerator-thread-app.matter | 8 ++++---- .../silabs/data_model/refrigerator-thread-app.zap | 8 ++++---- .../silabs/data_model/refrigerator-wifi-app.matter | 8 ++++---- .../silabs/data_model/refrigerator-wifi-app.zap | 8 ++++---- .../refrigerator-app/silabs/src/RefrigeratorManager.cpp | 1 - 5 files changed, 16 insertions(+), 17 deletions(-) diff --git a/examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.matter b/examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.matter index 08e150e59f..5aa4cf0929 100644 --- a/examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.matter +++ b/examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.matter @@ -1960,8 +1960,8 @@ endpoint 2 { server cluster TemperatureControl { ram attribute temperatureSetpoint; - ram attribute minTemperature; - ram attribute maxTemperature; + ram attribute minTemperature default = -18; + ram attribute maxTemperature default = -15; ram attribute step; callback attribute generatedCommandList; callback attribute acceptedCommandList; @@ -1990,8 +1990,8 @@ endpoint 3 { server cluster TemperatureControl { ram attribute temperatureSetpoint; - ram attribute minTemperature; - ram attribute maxTemperature; + ram attribute minTemperature default = 0; + ram attribute maxTemperature default = 4; ram attribute step; callback attribute generatedCommandList; callback attribute acceptedCommandList; diff --git a/examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.zap b/examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.zap index 547f012eaf..65dae2e422 100644 --- a/examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.zap +++ b/examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.zap @@ -3860,7 +3860,7 @@ "storageOption": "RAM", "singleton": 0, "bounded": 0, - "defaultValue": "", + "defaultValue": "-18", "reportable": 1, "minInterval": 1, "maxInterval": 65534, @@ -3876,7 +3876,7 @@ "storageOption": "RAM", "singleton": 0, "bounded": 0, - "defaultValue": "", + "defaultValue": "-15", "reportable": 1, "minInterval": 1, "maxInterval": 65534, @@ -4207,7 +4207,7 @@ "storageOption": "RAM", "singleton": 0, "bounded": 0, - "defaultValue": "", + "defaultValue": "0", "reportable": 1, "minInterval": 1, "maxInterval": 65534, @@ -4223,7 +4223,7 @@ "storageOption": "RAM", "singleton": 0, "bounded": 0, - "defaultValue": "", + "defaultValue": "4", "reportable": 1, "minInterval": 1, "maxInterval": 65534, diff --git a/examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter b/examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter index d77a827ff0..d51a109ad4 100644 --- a/examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter +++ b/examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter @@ -1867,8 +1867,8 @@ endpoint 2 { server cluster TemperatureControl { ram attribute temperatureSetpoint; - ram attribute minTemperature; - ram attribute maxTemperature; + ram attribute minTemperature default = -18; + ram attribute maxTemperature default = -15; ram attribute step; callback attribute generatedCommandList; callback attribute acceptedCommandList; @@ -1897,8 +1897,8 @@ endpoint 3 { server cluster TemperatureControl { ram attribute temperatureSetpoint; - ram attribute minTemperature; - ram attribute maxTemperature; + ram attribute minTemperature default = 0; + ram attribute maxTemperature default = 4; ram attribute step; callback attribute generatedCommandList; callback attribute acceptedCommandList; diff --git a/examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.zap b/examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.zap index 8232168b67..a1a4a96399 100644 --- a/examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.zap +++ b/examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.zap @@ -3749,7 +3749,7 @@ "storageOption": "RAM", "singleton": 0, "bounded": 0, - "defaultValue": "", + "defaultValue": "-18", "reportable": 1, "minInterval": 1, "maxInterval": 65534, @@ -3765,7 +3765,7 @@ "storageOption": "RAM", "singleton": 0, "bounded": 0, - "defaultValue": "", + "defaultValue": "-15", "reportable": 1, "minInterval": 1, "maxInterval": 65534, @@ -4096,7 +4096,7 @@ "storageOption": "RAM", "singleton": 0, "bounded": 0, - "defaultValue": "", + "defaultValue": "0", "reportable": 1, "minInterval": 1, "maxInterval": 65534, @@ -4112,7 +4112,7 @@ "storageOption": "RAM", "singleton": 0, "bounded": 0, - "defaultValue": "", + "defaultValue": "4", "reportable": 1, "minInterval": 1, "maxInterval": 65534, diff --git a/examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp b/examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp index 09ab827e9d..3edb405a76 100644 --- a/examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp +++ b/examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp @@ -102,7 +102,6 @@ void RefrigeratorManager::TempCtrlAttributeChangeHandler(EndpointId endpointId, case TempCtrlAttr::TemperatureSetpoint::Id: { int16_t temperatureSetpoint = ConvertToPrintableTemp(static_cast(*value)); mTemperatureSetpoint = temperatureSetpoint; - TempCtrlAttr::TemperatureSetpoint::Set(endpointId, temperatureSetpoint); } break; default: {