Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'INF' status to TTG for BMV #56

Open
eriksnijder opened this issue Aug 11, 2023 · 3 comments
Open

Add 'INF' status to TTG for BMV #56

eriksnijder opened this issue Aug 11, 2023 · 3 comments
Labels
good first task Good for newcomers

Comments

@eriksnijder
Copy link

I have a dashboard with my BMV712 data to (remote) monitor my sailboat. When connected to the battery charger the dashboard shows -60 which suggest that if the TTG is INF (as displayed in the BMV) the value of -1 is provided.
I would like to propose to add the following lines to the field.js file after line 226:

else if ( value === -1) { return 'INF' }

Regards, Erik

@sbender9
Copy link
Member

Returning null would make more sense. This field is a number, it should never be a string.

@sbender9
Copy link
Member

Also the venus plugin sends null in this case.

@eriksnijder
Copy link
Author

I'm fine with that, as long as my dashboard doesn't show -60

@tkurki tkurki added the good first task Good for newcomers label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first task Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants