From 82d7a1d13fe60c29df353b7b310162a56cd2516c Mon Sep 17 00:00:00 2001
From: Teppo Kurki <teppo.kurki@iki.fi>
Date: Sun, 4 Dec 2022 22:51:30 +0200
Subject: [PATCH] fix: bad MMSI handling (#254)

n2k-signalk is not expecting values to be zero length
https://github.com/SignalK/signalk-server/blob/f800fc9c62b249dc9c7f67252339408b0d8fa304/packages/streams/n2k-signalk.js#L121-L122
so if the MMSI seems to be not ok return undefined, as
any of the data in the delta don't make any sense with
a questionable MMSI.
---
 n2kMapper.js               | 4 ++--
 test/129038_ais_class_a.js | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/n2kMapper.js b/n2kMapper.js
index 6f2bfa3..e82f027 100644
--- a/n2kMapper.js
+++ b/n2kMapper.js
@@ -190,8 +190,8 @@ var toDelta = function (n2k, state, customPgns = {}) {
         //filter out invalid mmsi
         let last = result.context.lastIndexOf(':')
         if ( last != -1 && result.context.slice(last+1).length < 9 ) {
-          console.log('BAD: ' + result.context)
-          result.updates = []
+          console.error('bad MMSI: ' + result.context)
+          return
         }
       }
 
diff --git a/test/129038_ais_class_a.js b/test/129038_ais_class_a.js
index c6f7629..19dfbe4 100644
--- a/test/129038_ais_class_a.js
+++ b/test/129038_ais_class_a.js
@@ -80,7 +80,8 @@ describe('129038 Class A Update', function () {
       "description": "AIS Class A Position Report",
       "timestamp": "2022-05-09T13:38:38.917Z"
     }
-    mapper.toDelta(msg, {}).updates.length.should.equal(0)
+    const deltaType = typeof mapper.toDelta(msg, {})
+    deltaType.should.equal('undefined')
   })
 })