-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👜🦺 ↝ Adding planet editor, profile hooks #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've got some 3d planets being rendered in javascript, these are based on the initial C# algorithms in Signal-K/starsailors#4, Signal-K/starsailors-boilerplate#1 We've got some plans to generate nfts from this: Signal-K/sytizen#18. The models here are based on the C# model, we'll have an API call setup later so that they're both equivalent to each other directly. Next step is setting up some image exports and saving user data, providing a way for users to export the 3JS graphic to their Supabase storage row. That will be commenced later on tonight. All the fields will be set to be callable via an API & we will compare the output of different Deepnote graphs generated from `lightkurve` to provide further adjustments to either end. One issue is that on the frontend for the generator, some of the components aren't selectable. This is because the original example components were built for a much older version of React>Next. Since these will be callable via a custom API, and the editor will be changed to be a form, that won't be an issue. Docs available at the central issues on signal-k org Signal-K/marketplace#19 Signal-K/marketplace#3 Signal-K/marketplace#7 Signal-K/Silfur#26 -> These will be added to posts on the image/comment sharing part of the site (and later on Lens -> team members can refer to the roadmap) so that will be routed internally.
Also updated header component to provide links to the section Signal-K/sytizen#16 Temporarily had to remove the `Threads` hooks because being unfinished, they were causing build errors. They will be re-added later. Vercel has now been updated with a new test link -> check out the generator https://starprotocol-gizmotronn.vercel.app/generator/planet-editor Documentation on the gallery is available here: https://skinetics.notion.site/Supabase-Primer-6cf6c0e31fe6421b9fe0f084d8bad0e5
Changelog: Moved the gallery components into the offchain account section. Added new feature where users can take a screenshot of the planet they've created Currently, the screenshot is saved as an image URI string (see bottom of commit for e.g.), which is a problem as it is then uploaded to Supabase as a URI. What we need to do is convert the URI to an image inside the app (without saving it as a file on the app (as in a png file being saved next to the jsx file). This could be done before it's uploaded to Supabase, or when it's retrieved... Signal-K/sytizen#18 Signal-K/sytizen#16
…contract This is the first step of our new attempt at fixing Signal-K/Silfur#25 I've started merging the CSS into a new `styles/Proposals` directory in the next client, converted the calculater functions to typescript, and adding the context as a wrapper around the rest of the app (inside Thirdweb -> Moralis [providers]). We'll take the `<Sidebar />` component from https://github.com/Signal-K/sytizen/tree/main/client and have that be a persistent component on all pages INSIDE the `pages/Proposals` directory. We can remove the usage of `react-router-dom` by just putting a page inside that directory, and then creating a `[...id].tsx` file for the proposals dynamic routes, thus making it Next compatible. The context provider seems to be working fine. So we'll see how this goes.
Also fixed profile styling issue on my Lens profile (#7 #8 #9 #10 #11 #12): https://www.notion.so/skinetics/Threaded-Comments-2nd-iteration-flow-475d8a2328be4be8a1403256f094790e#61f363eddac74572b243ebb0c9c6513a Signal-K/sytizen#16
…ta for offchain auth
Gizmotronn
added
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
nft-interaction
postgres
auth
labels
Feb 2, 2023
Gizmotronn
commented
Feb 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auth
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
nft-interaction
postgres
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Problems
a. Having issues with state management (for different styling) based on page links
b. User profile components are not tabbed (navlinks on profile section don't work)
useUser
&useSession
from SupabaseThe potential solution here would be to separate the off chain account into a separate Next app and then add the coffeescripts for the Lens interaction straight after, and then edit the
OffchainAccount
component to useuseSession
. @Nathan5563 should look into the differences betweenuseSession
&useUser
in Next.Refs
Referencing #16, as well as repo from Signal-K/plugins#1