Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy build the layered strategies, so it is not initialized before it's actually needed. Some models will never use their LayeredCache, so there's no use to initializing it before it's needed. #890

Open
Tracked by #873
SigmundGranaas opened this issue Apr 14, 2024 · 0 comments
Labels
performance Better or worse performance

Comments

@SigmundGranaas
Copy link
Owner

This might make the model system more performant but it probably won't make a huge difference.

@SigmundGranaas SigmundGranaas added the performance Better or worse performance label Apr 14, 2024
SigmundGranaas added a commit that referenced this issue Apr 14, 2024
## Baked model selection rewrite
Closes #870 
Closes #865 

**Goal**: Rebuild the model selection process to be more flexible and
easier to maintain

## Changes
* Removes the old monolith class that handled everything before
* Removed itemstack cache keys
* Removed the old 
* Removed dependency on the deprecated Fabric Model selection api

* Adds a new 1-1 binding between items and the Unbaked model class
* Implemented using Fabric's new ModelLoadingPlugin
* Adds a system of decorator strategies to be able to quickly set up and
build a BakedModel selection process
* Added the following selectors: AsyncStrategy, SingleCachedStrategy,
LayeredCachedStrategy, DefaultedBakedModelStrategy, ModelBakerStrategy


## Compatibility
* Adds compat for Modernfix
* Adds compat for Emissive Textures plugin

## Further work
- [ ]  #890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Better or worse performance
Projects
None yet
Development

No branches or pull requests

1 participant