Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Changes #139

Merged
merged 32 commits into from
Aug 6, 2024
Merged

Final Changes #139

merged 32 commits into from
Aug 6, 2024

Conversation

nasbench
Copy link
Member

@nasbench nasbench commented Aug 4, 2024

TODO

  • Update pySigma tags check for the CVE and detection namespaces to use dashes - instead of dots and underscores. (See update tags to use dashes pySigma#248)
  • Update the related type from obsoletes to obsolete
  • Update the mitre att&ck tags description to use dashes instead of underscore for tactics.
  • Update the VsCode Sigma extension to generate the correct dates and tags formats. (See update tags and date format humpalum/vscode-sigma#24)
  • Update the taxonomy to include all of the latest logsources.
  • Make sure the JSON schema used in SigmaHQ rule repo is the latest version provided by the spec.
  • Update and restructure the README
  • Check for typos
  • Update the rules on the SigmaHQ rule repo to use the new tags and dates format (See Comply With V2 Spec Changes sigma#4950)
    • Update the date field
    • Update the modified field
    • Update the type field to use Obsolete
    • Update the cve tag to use -
    • Update the detection tag to use -
    • Update the attack tag to use -
    • Fix the tests
  • Update TLP tags to follow the listing in https://www.first.org/
  • Update the links on the Wiki to points to the correct files in the spec.

@nasbench nasbench marked this pull request as draft August 4, 2024 15:58
@nasbench nasbench marked this pull request as ready for review August 5, 2024 10:40
@nasbench nasbench self-assigned this Aug 5, 2024
@nasbench nasbench added this to the Version 2.0.0 milestone Aug 5, 2024
Copy link
Member

@frack113 frack113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nasbench nasbench merged commit 3c7f04b into SigmaHQ:version_2 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants