Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output: Preview UI for color tokens #13

Open
Sidnioulz opened this issue Nov 20, 2024 · 1 comment
Open

Output: Preview UI for color tokens #13

Sidnioulz opened this issue Nov 20, 2024 · 1 comment

Comments

@Sidnioulz
Copy link
Owner

Sidnioulz commented Nov 20, 2024

Examples

All

Nord Health includes a contrast score ⭐
Image
Image

FTV
Image

Polaris
Image

Druid
Image

BG

Wikimedia
Image

Pinterest
Image

Border

Wikimedia
Image

Pinterest
Image

Text

Wikimedia with a #ffffff1a 1px border
Image

Pinterest
Image

Other

Wikimedia
Image

Challenges

  • Few systems distinguish fg/border color visualisations from bg; should we follow that trend?
  • How to handle colors that are very close to the current page bg color? should that be detected and handled with a border?
@Sidnioulz Sidnioulz converted this from a draft issue Nov 20, 2024
@drwpow
Copy link
Collaborator

drwpow commented Dec 1, 2024

How to handle colors that are very close to the current page bg color?

Just a thought—I think users should be able to set their own BG color (assuming we’re talking, like, #f0f0f0 as opposed to #ffffff). Otherwise, it does affect the perceived values of their entire color system (e.g. their palette could be beautifully-optimized for an off-white background, but colors look too dark on pure white).

Few systems distinguish fg/border color visualisations from bg; should we follow that trend?

This has always perplexed me. Why not make it clear how the token is used? I’ve always assumed it’s just laziness, and reusing the same color component for everything. Maybe I’m wrong, but personally I’d rather see only text colors used as text and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposal/RFC
Development

No branches or pull requests

2 participants