Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renterd config enables S3 when not asked #1612

Open
mike76-dev opened this issue Oct 19, 2024 · 1 comment · May be fixed by #1617
Open

renterd config enables S3 when not asked #1612

mike76-dev opened this issue Oct 19, 2024 · 1 comment · May be fixed by #1617
Labels
bug Something isn't working
Milestone
v2.0.0

Comments

@mike76-dev
Copy link
Contributor

Current Behavior

The setup wizard of renterd config asks whether I want to configure the S3 settings. If I say "no", it still generates a renterd.yml file where s3: enabled equals to true.

Expected Behavior

If I tell renterd config that I do not want to configure the S3 settings, I imply that I do not want to enable S3. Therefore, it needs to be disabled in the config file.

Steps to Reproduce

  1. Run renterd config.
  2. Say "no" to "would you like to configure S3 settings".

Version

v1.1.0-beta.5

What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?

Ubuntu 24.04

Autopilot Config

N/A

Bus Config

N/A

Contract Set Contracts

N/A

Anything else?

No response
@mike76-dev mike76-dev added the bug Something isn't working label Oct 19, 2024
@ChrisSchinnerl ChrisSchinnerl added this to the v2.0.0 milestone Oct 21, 2024
@ChrisSchinnerl
Copy link
Member

Right now saying "no" to "Would you like to configure X" doesn't mean that X gets disabled but rather that you don't configure it and accept the defaults. Which for S3 is "enabled".

We can follow up with another prompt "Would you like to enable the S3 gateway" though which can then be used to enable/disable S3 explicitly. The default is "enabled" because there is no harm in doing so. Without creating any keys, nothing can access the gateway.

@chris124567 chris124567 linked a pull request Oct 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Sia
Status: Todo
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Add extra prompt to enable/disable s3 gateway if user declines configuring it SiaFoundation/renterd
2 participants
@ChrisSchinnerl @mike76-dev