💄 Make access easier to the companies' link #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the Jobs column left next to the Name column - Convert companies' name from plain text to hyperlink
|
@SiaExplains Just for remind. |
|
Anybody there! |
SiaExplains
approved these changes
Oct 13, 2023
SiaExplains
reviewed
Oct 13, 2023
src/app/page.tsx
Outdated
| @@ -106,6 +106,7 @@ export default function Home() { | |||
| <table> | |||
| <tbody> | |||
| <tr> | |||
| <th>Jobs</th> | |||
There was a problem hiding this comment.
What if we change this Jobs heading? Since this app is not referring jobs and only it is showing companies that offered job offer to abroad employees, maybe we can remove this heading or rename it somethings more relevant. What do you think?
There was a problem hiding this comment.
Indeed, I think it's sort of redundant (not relevant).
So, I will send another tiny PR.
|
Thanks so much @ykh , Approved + one small suggestion. |
- Move LinkedIn icon next to company name. - Make whole space of Name cell clickable (easier to click on the link).
|
Little new changes: Just for keep the previous user-experience I didn't remove the LinkedIn icon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes preview:
