Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

webpack warning: theme-product-form has incorrect peer dependency #105

Open
tms320c opened this issue Aug 1, 2019 · 4 comments
Open

webpack warning: theme-product-form has incorrect peer dependency #105

tms320c opened this issue Aug 1, 2019 · 4 comments

Comments

@tms320c
Copy link

tms320c commented Aug 1, 2019

Webpack reports a warning:

@shopify/[email protected]" has incorrect peer dependency "@shopify/theme-product@^1.0.0"

@hugoburguete
Copy link

I am seeing this issue as well which is actually starting to throw errors for the latest version of NPM (7.5.2).

It would be good if the latest version of theme-product-form (currently 4.1.0) required a more up to date version of the package (maybe 3.0.0) as if you need both the packages, you can only have the version 1 of theme-product.

@richayles
Copy link

It looks like there is a Pull Request for this already - #138 can someone push it through?

@hugoburguete
Copy link

hugoburguete commented Mar 9, 2021

@chrisberthe Although the PR has been merged, the error is still present. Looking at the node_modules folder, I can confirm I have the latest version of the package but the peer dependency hasn't been updated.

image

Could this be an update needed in NPM's side?

EDIT: Possibly an update in the 4.1.0 tag would fix this: https://github.com/Shopify/theme-scripts/blob/v4.1.0/packages/theme-product-form/package.json

@tauthomas01
Copy link
Contributor

Hi, the update is now published via npm

Let me know if there's anything else.
Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants