From 9cc725667099d31876c37696eec6281dd6de14ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pedro=20Pi=C3=B1era?= Date: Fri, 14 Jan 2022 12:19:12 +0100 Subject: [PATCH 1/2] Rename registration-id to extension-id --- lib/project_types/extension/commands/push.rb | 2 +- lib/project_types/extension/messages/messages.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/project_types/extension/commands/push.rb b/lib/project_types/extension/commands/push.rb index 209b9a119e..9bc671fcd5 100644 --- a/lib/project_types/extension/commands/push.rb +++ b/lib/project_types/extension/commands/push.rb @@ -9,7 +9,7 @@ class Push < ShopifyCLI::Command::SubCommand options do |parser, flags| parser.on("--api-key=API_KEY") { |api_key| flags[:api_key] = api_key.gsub('"', "") } parser.on("--api-secret=API_SECRET") { |api_secret| flags[:api_secret] = api_secret.gsub('"', "") } - parser.on("--registration-id=REGISTRATION_ID") do |registration_id| + parser.on("--extension-id=EXTENSION_ID") do |registration_id| flags[:registration_id] = registration_id.gsub('"', "") end end diff --git a/lib/project_types/extension/messages/messages.rb b/lib/project_types/extension/messages/messages.rb index 2d52db5a01..84432159ab 100644 --- a/lib/project_types/extension/messages/messages.rb +++ b/lib/project_types/extension/messages/messages.rb @@ -91,7 +91,7 @@ module Messages Usage: {{command:%s extension push}} Options: {{command:--api-key=API_KEY}} Connect your extension and app by inserting your app's API key (which you can get from your app setup page on shopify.dev). - {{command:--registration-id=REGISTRATION_ID}} The id of the extension's registration. + {{command:--extension-id=EXTENSION_ID}} The id of the extension's registration. HELP frame_title: "Pushing your extension to Shopify", waiting_text: "Pushing code to Shopify…", From 33655b242b23e7a8f3fff47c3abc13b5b8a5c225 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pedro=20Pi=C3=B1era?= Date: Fri, 14 Jan 2022 12:27:03 +0100 Subject: [PATCH 2/2] Update the CHANGELOG --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e312724284..4b0dce1c41 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,9 @@ From version 2.6.0, the sections in this file adhere to the [keep a changelog](h * [#1891](https://github.com/Shopify/shopify-cli/pull/1891): Allow for additional arguments in `shopify push script` on CI. * [#1877](https://github.com/Shopify/shopify-cli/pull/1877): Add theme (`-t`/`--theme=NAME_OR_ID`) parameter to `theme push`/`theme pull` commands +### Changed +- [#1929](https://github.com/Shopify/shopify-cli/pull/1929): Rename `--registration-id` to `--extension-id` in `shopify extension push`. + ## Version 2.8.0 ### Fixed * [#1879](https://github.com/Shopify/shopify-cli/pull/1879): Disambiguate -s as store option