Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied gift card #2298

Merged
merged 19 commits into from
Aug 16, 2024
Merged

Applied gift card #2298

merged 19 commits into from
Aug 16, 2024

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Jul 4, 2024

WHY are these changes introduced?

  • Add the newly introduced cartGiftCardCodesUpdate mutation to cartCreateHandler
  • Update skeleton template to handle gift card codes

Todo

  • Update example code

WHAT is this pull request doing?

HOW to test your changes?

  1. Go to admin and create a couple gift cards, these code are one-time view only so keep a copy it of it.
  2. Run skeleton template and add an item to cart
  3. Add gift card codes
  4. Go to checkout and see they are applied

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

This comment has been minimized.

Copy link
Contributor

shopify bot commented Jul 4, 2024

Oxygen deployed a preview of your hl-applied-gift-cards branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 5, 2024 7:47 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment August 16, 2024 9:09 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 5, 2024 7:47 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 5, 2024 7:47 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 5, 2024 7:47 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 5, 2024 7:47 PM

Learn more about Hydrogen's GitHub integration.

Base automatically changed from mc-update-api to main July 5, 2024 19:19
Copy link
Contributor

@juanpprieto juanpprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@wizardlyhel wizardlyhel merged commit d929b56 into main Aug 16, 2024
13 checks passed
@wizardlyhel wizardlyhel deleted the hl-applied-gift-cards branch August 16, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants