Make sure 400-500 level HTTP sub-requests are not cached (#1907)

Shopify · Mar 26, 2024 · 73b4dc8 · 73b4dc8
1 parent 44ac882
commit 73b4dc8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/shy-houses-rest.md b/.changeset/shy-houses-rest.md
@@ -0,0 +1,5 @@
+---
+'@shopify/hydrogen': patch
+---
+
+Make sure 400-500 sub-requests are not cached
diff --git a/packages/hydrogen/src/cache/fetch.ts b/packages/hydrogen/src/cache/fetch.ts
@@ -55,7 +55,8 @@ function fromSerializableResponse([body, init]: [any, ResponseInit]) {
 
 // Check if the response body has GraphQL errors
 // https://spec.graphql.org/June2018/#sec-Response-Format
-export const checkGraphQLErrors = (body: any) => !body?.errors;
+export const checkGraphQLErrors = (body: any, response: Response) =>
+  !body?.errors && response.status < 400;
 
 // Lock to prevent revalidating the same sub-request
 // in the same isolate. Note that different isolates