You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is nothing in the code that protects us from misconfiguration of ProgressReportFrequency. Setting it to zero or a negative number, for example. There should probably be a minimum allowable value, where we we either clamp to that minimum, or we skip the progress reporting completely if the value is lower.
The text was updated successfully, but these errors were encountered:
milanatshopify
changed the title
Setting Config.ProgressReportFrequency to a 0 or negative number would be bad
Setting Config.ProgressReportFrequency to a small or negative number would be bad
Oct 5, 2020
It could be as simple as that! In particular, because the value is ms, it may be easy for somebody to set a value off by 100, and end up with something way too frequent. A reasonable minimum would take care of that. I won't comment on whether 1 minute is a reasonable minimum :)
There is nothing in the code that protects us from misconfiguration of ProgressReportFrequency. Setting it to zero or a negative number, for example. There should probably be a minimum allowable value, where we we either clamp to that minimum, or we skip the progress reporting completely if the value is lower.
@xliang6
The text was updated successfully, but these errors were encountered: