Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Page: Order History table shows total price in the selected currency, instead of the actual order currency #1613

Open
muriloshimizu opened this issue Apr 12, 2022 · 4 comments

Comments

@muriloshimizu
Copy link

Describe the current behavior
When a customer goes to the account page and views the order history table, all the order totals are in the currency of the currently selected country (Country selector, eg: added in the footer). The main problems I see:

  1. The order happened in the past, with transactions on a currency that was locked when the order happened. It shouldn't change currency based on what you select on any language/currency selector.

  2. The currency symbol and iso codes change, but the value isn't actually converted. Example: $10 USD order placed, then we change the country to Spain... and it will display €10 EUR. This is very misleading and frustrating, specially in cases where the exchange rates aren't in favour of the customer.

Images below:

Screen Shot 2022-04-12 at 1 59 09 pm

Screen Shot 2022-04-12 at 1 59 53 pm

Screen Shot 2022-04-12 at 2 14 44 pm

On the order page, the currency is correct.

Screen Shot 2022-04-12 at 2 17 38 pm

I believe this isn't a dawn-specific issue, more like a liquid/shopify issue... not sure.

Describe the expected behavior
Order currency should be locked and displayed on the order history table (accounts page) according to the actual currency it was placed on.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 4.0.0
  • Chrome Version 100.0.4896.75 (Official Build) (x86_64)
  • macOS Version 12.3.1
@richilton
Copy link

I have just hit the same problem. My workaround was to render the amounts as follows:

{{ order.total_price | money_without_currency }} {{ order.currency }}

This outputs something like "19.99 GBP".

However, order.currency is not mentioned in the Liquid documentation, so I'm not sure if it is safe to use. And it isn't very elegant – the currency symbol isn't rendered, for example.

@arnoldoosterom
Copy link

The company I work with started to use Global-E (Shopify Markets Pro) and their Q&A is also telling me this is a problem. Strange that Shopify again completes ignores this.

@KhangNguyen303
Copy link

Wow they did not resolve it yet

@EranBendheim
Copy link

Thank U :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants