From b43121f6801df28421c404c9018f60c9b550de58 Mon Sep 17 00:00:00 2001 From: James Meng Date: Tue, 24 Sep 2024 11:41:12 -0700 Subject: [PATCH 1/2] Update exports --- packages/cli/src/index.ts | 1 + packages/theme/src/index.ts | 16 +++++----------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/packages/cli/src/index.ts b/packages/cli/src/index.ts index eda8f3a318..60985c0a01 100644 --- a/packages/cli/src/index.ts +++ b/packages/cli/src/index.ts @@ -28,6 +28,7 @@ export {default as TunnelStartHook} from '@shopify/plugin-cloudflare/hooks/tunne export {default as TunnelProviderHook} from '@shopify/plugin-cloudflare/hooks/provider' export {hooks as PluginHook} from '@oclif/plugin-plugins' export {AppSensitiveMetadataHook, AppInitHook, AppPublicMetadataHook} from '@shopify/app' +export {push, pull, fetchStoreThemes} from '@shopify/theme' export const HydrogenInitHook = HydrogenHooks.init diff --git a/packages/theme/src/index.ts b/packages/theme/src/index.ts index b5453c98ca..b3caa86af4 100644 --- a/packages/theme/src/index.ts +++ b/packages/theme/src/index.ts @@ -14,9 +14,6 @@ import Push from './cli/commands/theme/push.js' import Rename from './cli/commands/theme/rename.js' import Serve from './cli/commands/theme/serve.js' import Share from './cli/commands/theme/share.js' -import {pull} from './cli/services/pull.js' -import {push} from './cli/services/push.js' -import {publicFetchStoreThemes} from './cli/utilities/theme-selector/fetch.js' const COMMANDS = { 'theme:init': Init, @@ -37,14 +34,6 @@ const COMMANDS = { 'theme:share': Share, } -const PUBLIC_COMMANDS = { - pull, - push, - publicFetchStoreThemes, -} - -export {PUBLIC_COMMANDS} - export default COMMANDS /** Development server for theme extensions */ @@ -53,3 +42,8 @@ export * from './cli/utilities/theme-ext-environment/theme-ext-server.js' /** Storefront authentication support for running the development server on password-protected stores */ export {isStorefrontPasswordProtected} from './cli/utilities/theme-environment/storefront-session.js' export {ensureValidPassword} from './cli/utilities/theme-environment/storefront-password-prompt.js' + +// Public Theme Commands +export {pull} from './cli/services/pull.js' +export {push} from './cli/services/push.js' +export {publicFetchStoreThemes as fetchStoreThemes} from './cli/utilities/theme-selector/fetch.js' From 967447be8acb1b25a12eb3068376edf3d613ef50 Mon Sep 17 00:00:00 2001 From: James Meng Date: Thu, 26 Sep 2024 09:07:41 -0700 Subject: [PATCH 2/2] Improve export comment in index file --- packages/theme/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/theme/src/index.ts b/packages/theme/src/index.ts index b3caa86af4..387acb05db 100644 --- a/packages/theme/src/index.ts +++ b/packages/theme/src/index.ts @@ -43,7 +43,7 @@ export * from './cli/utilities/theme-ext-environment/theme-ext-server.js' export {isStorefrontPasswordProtected} from './cli/utilities/theme-environment/storefront-session.js' export {ensureValidPassword} from './cli/utilities/theme-environment/storefront-password-prompt.js' -// Public Theme Commands +// Expose core utilities for developers to build and expand on the CLI export {pull} from './cli/services/pull.js' export {push} from './cli/services/push.js' export {publicFetchStoreThemes as fetchStoreThemes} from './cli/utilities/theme-selector/fetch.js'