-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TOML configuration for function build path #4622
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
/snapit |
Coverage report
Test suite run success1943 tests passing in 876 suites. Report generated by 🧪jest coverage report action from 083aaaf |
🫰✨ Thanks @andrewhassan! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g @shopify/[email protected]
|
ce33ee6
to
fbbac24
Compare
/snapit |
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
🫰✨ Thanks @andrewhassan! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g @shopify/[email protected]
|
fbbac24
to
083aaaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this feature simply not work before? 🤔 Or is this net-new?
Also- is this something worth testing? Or are we considering our smoke tests to be sufficient here?
@DuncanUszkay1 This is a net new bug from this PR, which was shipped yesterday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see now. Thanks for the context
#gsd:40977
WHY are these changes introduced?
Fixes https://github.com/Shopify/shopify-functions/issues/445
WHAT is this pull request doing?
Function developers have the option of specifying a custom build path for their Wasm file. This PR updates the CLI code to read from that path if it's specified, otherwise use the default path of
dist/index.wasm
(described here).How to test your changes?
target/wasm32-wasi/release/my-function.wasm
)shopify app deploy
Measuring impact
How do we know this change was effective? Please choose one:
Checklist