Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CLI Timeout and fails to persistently keep renegotiating connection #4598

Closed
2 tasks done
JamiesonRoberts opened this issue Oct 8, 2024 · 2 comments · Fixed by #4599
Closed
2 tasks done

[Bug]: CLI Timeout and fails to persistently keep renegotiating connection #4598

JamiesonRoberts opened this issue Oct 8, 2024 · 2 comments · Fixed by #4599
Assignees
Labels
Area: @shopify/theme @shopify/theme package issues #gsd:40767 Fortify local development experience for Liquid themes important second highest severity for theme related bug Type: Bug Something isn't working

Comments

@JamiesonRoberts
Copy link

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

If the theme CLI is left running in the background, it shouldn't timeout or just stop spontaneously and should automatically renegotiation any tokens and just keep running.

Actual behavior

Unknown on exact timing, but the CLI will just randomly stop working and present the following error. Sometimes it will be after a period of inactivity, sometimes it will just stop working and not re-negotiate the connection while actively using the CLI to updated files while building things

Error: [401] API request unauthorized error
    at request (file:///opt/homebrew/Cellar/shopify-cli/3.68.0/libexec/lib/node_modules/@shopify/cli/dist/index.js:145224:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async fetchChecksums (file:///opt/homebrew/Cellar/shopify-cli/3.68.0/libexec/lib/node_modules/@shopify/cli/dist/index.js:145198:17)
    at async pollRemoteJsonChanges (file:///opt/homebrew/Cellar/shopify-cli/3.68.0/libexec/lib/node_modules/@shopify/cli/dist/index.js:148436:97)

Verbose output

N/A

Reproduction steps

  1. Start up the CLI
  2. Leave it running for a time period (can't get an exact timing on it, but my guess is at least an hour or 2)
  3. See the timeout and failure to renegotiate

Operating System

macOS Sonoma 14.6.1

Shopify CLI version (check your project's package.json if you're not sure)

3.68.0

Shell

iTerm + ZSH

Node version (run node -v if you're not sure)

20.10.0

What language and version are you using in your application?

No response

@JamiesonRoberts JamiesonRoberts added the Type: Bug Something isn't working label Oct 8, 2024
@JamiesonRoberts JamiesonRoberts changed the title [Bug]: <YOUR ISSUE TITLE> [Bug]: CLI Timeout and fails to persistently keep renegotiating connection Oct 8, 2024
@frandiox
Copy link
Contributor

frandiox commented Oct 8, 2024

This is also reported here but showing a different symptom: #4576
We'll address this soon.

@karreiro karreiro added Area: @shopify/theme @shopify/theme package issues important second highest severity for theme related bug #gsd:40767 Fortify local development experience for Liquid themes labels Oct 8, 2024
@karreiro karreiro linked a pull request Oct 8, 2024 that will close this issue
5 tasks
@JamiesonRoberts
Copy link
Author

@frandiox I wasn't 100% sure if it was the same issue given the different error code so I created this one, sorry about the duplication!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues #gsd:40767 Fortify local development experience for Liquid themes important second highest severity for theme related bug Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants