[Bug]: app config:link
brings extra slash from application_url
into toml which causes app deploy
to register relative webhooks with double slashes
#4511
Labels
Type: Bug
Something isn't working
Please confirm that you have:
In which of these areas are you experiencing a problem?
App
Expected behavior
When I run
app deploy
, and if t he webhook'suri
is set correctly as per documentation, it shouldn't add extra slashes.This is important for our workflow as we have different environments that are actually separate apps, so we often switch
toml
files for the same app, but deploys are risky due to this.Actual behavior
When you have a set production (or dummy) url set in
application_url
such as:and then run again
app config:link
followed by anapp deploy
you will notice that it changes toand that if you had configured any webhooks in the toml relatively, they will get double starting slashes such has:
Verbose output
which command should I run with verbose?
Reproduction steps
npm init @shopify/app@latest
npm run dev
, when it asks to automatically update urls, selectNo, never
.https://demo.com
and the redirection url tohttps://demo.com/api/auth
.npm run config:link
, selecting existing app.npm run deploy
as the the template should already come with some pre-set webhooks inshopify.app.toml.
This issue is not limited to the compliance webhooks, these are just the ones visible from the dashboard (btw, feature request to see all config-managed subscriptions from the dashboard 🙏🏻) All webhooks subscribed with the CLI end up having double slashes and failing deliveries!
Operating System
Windows 11
Shopify CLI version (check your project's
package.json
if you're not sure)3.67.1
Shell
powershell
Node version (run
node -v
if you're not sure)v20.11.1
What language and version are you using in your application?
Typescript
The text was updated successfully, but these errors were encountered: