From 5047a36d31f0ef52cbab7f7fea158013793d9953 Mon Sep 17 00:00:00 2001 From: Shaun Stanworth Date: Fri, 18 Oct 2024 10:46:37 +0100 Subject: [PATCH] Drop any ruby CI checks --- .github/workflows/changelog-reminder.yml | 4 +- .github/workflows/checks.yml | 2 - .github/workflows/cli-ruby.yml | 77 ------------------------ 3 files changed, 2 insertions(+), 81 deletions(-) delete mode 100644 .github/workflows/cli-ruby.yml diff --git a/.github/workflows/changelog-reminder.yml b/.github/workflows/changelog-reminder.yml index 10f2b190f0..ba66943524 100644 --- a/.github/workflows/changelog-reminder.yml +++ b/.github/workflows/changelog-reminder.yml @@ -1,7 +1,7 @@ on: pull_request: types: [opened, synchronize, reopened, ready_for_review] - paths: ['packages/*/src/**', 'packages/cli-kit/assets/cli-ruby/**'] + paths: ['packages/*/src/**'] name: Changelog Reminder jobs: remind: @@ -14,5 +14,5 @@ jobs: with: changelogRegex: \.changeset message: | - We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. + We detected some changes at packages/*/src and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG. diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 8111978b8b..7ce3af29be 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -10,8 +10,6 @@ env: SHOPIFY_CLI_ENV: development SHOPIFY_CONFIG: debug PNPM_VERSION: '8.15.7' - RUBY_VERSION: '3.1.2' - BUNDLER_VERSION: '2.3.18' jobs: type-diff: diff --git a/.github/workflows/cli-ruby.yml b/.github/workflows/cli-ruby.yml deleted file mode 100644 index 93f86c3a8f..0000000000 --- a/.github/workflows/cli-ruby.yml +++ /dev/null @@ -1,77 +0,0 @@ -name: cli-ruby - -on: - push: - branches: - - main - pull_request: - merge_group: - -concurrency: - group: shopify-${{ github.head_ref || github.run_id }} - cancel-in-progress: true - -defaults: - run: - working-directory: ./packages/cli-kit/assets/cli-ruby - -jobs: - test: - name: Tests with Ruby ${{ matrix.version }} on ${{ matrix.os }} - runs-on: ${{ matrix.os }} - timeout-minutes: 15 - strategy: - matrix: - version: - - 3.1.0 - - 3.0.2 - - 2.7.5 - os: - - macos-12 - - ubuntu-20.04 - - ubuntu-22.04 - steps: - - uses: actions/checkout@v3 - - name: Set Git configuration - run: | - git config --global user.email "app-management@shopify.com" - git config --global user.name "App Management" - - - name: Set up Ruby ${{ matrix.version }} - uses: ruby/setup-ruby@679e23d4a31bcf7cd0a69acd348e5f79e8c6b443 # pin@v1 - with: - ruby-version: ${{ matrix.version }} - bundler: 'latest' - bundler-cache: true - - - name: Install Dependencies - run: bundle install - - - name: Run Tests - run: bundle exec rake test - - rubocop: - name: Rubocop - runs-on: ${{ matrix.os }} - timeout-minutes: 15 - strategy: - matrix: - version: - - 3.1.0 - os: - - macos-12 - steps: - - uses: actions/checkout@v3 - - - name: Set up Ruby ${{ matrix.version }} - uses: ruby/setup-ruby@679e23d4a31bcf7cd0a69acd348e5f79e8c6b443 # pin@v1 - with: - ruby-version: ${{ matrix.version }} - bundler: 'latest' - bundler-cache: true - - - name: Install Dependencies - run: bundle install - - - name: Rubocop - run: bundle exec rake rubocop