Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Avoid the logout timer trying to acquire the lock twice #1200

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

fearnlj01
Copy link
Contributor

No description provided.

@revam revam requested a review from da3dsoul November 13, 2024 20:48
@fearnlj01
Copy link
Contributor Author

Woops, didn't mean to submit that without comment... But some experimentation suggested that LogoutTimerElapsed would acquire a lock, preventing the actual logout command from being able to lock.

(I think)

@da3dsoul
Copy link
Member

Have you tested that it at least logs out as expected?

@fearnlj01
Copy link
Contributor Author

I've done so when I had the logout timer set to two minutes, but can give it a more natural run on what I'm running now.

Will confirm again in ~5 minutes

@fearnlj01
Copy link
Contributor Author

Confirming that it logs out as expected in the "normal" test run, and allows for an immediate re-login afterwards without any errors 👍

@da3dsoul da3dsoul merged commit 51e529b into ShokoAnime:master Nov 13, 2024
@fearnlj01 fearnlj01 deleted the fix-double-lockout branch November 13, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants