Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some question regarding ref attention processor and IP attention processor. #88

Open
xiankgx opened this issue May 23, 2024 · 2 comments

Comments

@xiankgx
Copy link

xiankgx commented May 23, 2024

Dear author,

Thanks for your wonderful work.

However, I'm not sure how are you able to combine IPAdapterFaceID and reference attention.
If we look at the code for IP Adapter FaceID, they are replacing the attention processors for both the self attention block and also the cross attention block.

https://github.com/tencent-ailab/IP-Adapter/blob/main/ip_adapter/ip_adapter_faceid.py#L158-L162

where-areas you are applying only the IP adapter Face ID to the cross attention block.

https://github.com/ShineChen1024/MagicClothing/blob/earlyAccess/garment_adapter/garment_ipadapter_faceid.py#L190-L192

Please enlighten me. Thanks.
@ShineChen1024

@xiankgx
Copy link
Author

xiankgx commented May 23, 2024

Perhaps you are referring to this instead?

https://github.com/tencent-ailab/IP-Adapter/blob/main/ip_adapter/ip_adapter_faceid_separate.py#L157-L159C36

@ShineChen1024
Copy link
Owner

pipe.load_lora_weights(ip_lora)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants