Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]-IntakeSimulation does not register itself with SimulatedArena #71

Closed
mimizh2418 opened this issue Dec 24, 2024 · 1 comment
Closed

[BUG]-IntakeSimulation does not register itself with SimulatedArena #71

mimizh2418 opened this issue Dec 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mimizh2418
Copy link

Bug Description

The JavaDoc says that the IntakeSimulation constructor should call SimulatedArena::addIntakeSimulation automatically, but it doesn't do that, and the simulated intake will not work until IntakeSimulation::register is called.

Steps to Reproduce

  • Create a IntakeSimulation instance
  • Start the intake
  • The simulated intake will not intake gamepieces until register is called from user code
@catr1xLiu catr1xLiu mentioned this issue Dec 25, 2024
Merged
@catr1xLiu catr1xLiu added the bug Something isn't working label Dec 25, 2024
@catr1xLiu
Copy link
Contributor

#72 should fix this bug

I'll close this issue once the new version is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@catr1xLiu @mimizh2418