Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using value of code field as product id in Mailchimp may create conflicts on Mailchimp side #50

Open
broiniac opened this issue Jul 21, 2020 · 3 comments

Comments

@broiniac
Copy link
Contributor

broiniac commented Jul 21, 2020

When pushing Products to Mailchimp code field from Sylius is used as id in Mailchimp.
Mailchimp id field has (probably) undocumented requirement - it can't be longer then 50 chars. The problem is that Mailchimp is not throwing any error - instead it trims given value to 50 chars. So when code field is long enought it may generate quirks and errors while pushing products to Mailchimp.

For example:

Sylius Product:
code: zestaw_dos_argentinos_playadito_amanda_despalada_2kg
Mailchimp:
id: zestaw_dos_argentinos_playadito_amanda_despalada_2

So if there will be product in sylius with code like:
code: zestaw_dos_argentinos_playadito_amanda_despalada_200g
then Mailchimp will trim it to the exact same id creating conflict.

If Sylius id field is better choice, please remember, that Mailchimp id field has to be string.

I didn't check if other Mailchimp e-commerce models has same behavior (orders/customers/carts/etc).
Cart is not integrated for now. Order is using number field as Mailchimp Id, Customer is using id field, so we are good there.

@broiniac broiniac changed the title Using code as product id may create conflicts on Mailchimp side Using code field as product id may create conflicts on Mailchimp side Jul 21, 2020
@broiniac broiniac changed the title Using code field as product id may create conflicts on Mailchimp side Using value of code field as product id in Mailchimp may create conflicts on Mailchimp side Jul 21, 2020
@loevgaard
Copy link
Member

Hi @broiniac

Thanks for this issue. I used the code because most of the time the code is more useful for users than the id, but what you are presenting is a real problem.

I have an idea for a solution: We could pre- or append the Sylius id to the code and use this as the id in Mailchimp. Should probably be prepended if Mailchimp truncates the id. Then we would have something like this:

Id Code Id in Mailchimp
1 T_SHIRT 1-T_SHIRT
2 JEANS 2-JEANS

What do you think about that?

@loevgaard
Copy link
Member

Any news here, @broiniac? :)

@broiniac
Copy link
Contributor Author

That approach should be pretty easy to implement. It is important to remember, that id in Mailchimp still can be limited to 50 chars, so it should be truncated accordingly.
Sadly, product owner decided to move towards GetResponse. Since my workload is high, I can't take care of this one by myself in any near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants