Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Example Code Doesn't Compile #31

Open
JimLynchCodes opened this issue Oct 3, 2024 · 1 comment
Open

README Example Code Doesn't Compile #31

JimLynchCodes opened this issue Oct 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@JimLynchCodes
Copy link

JimLynchCodes commented Oct 3, 2024

Describe the bug
Example code is double wrong I think...

To Reproduce
Steps to reproduce the behavior:

  1. Create any Bevy project on bevy 0.14
  2. cargo add virtual_joystick
  3. Add the line from README:
.add_plugin(VirtualJoystickPlugin::<JoystickControllerID>::default())

This gives 1 error that "add_plugin" is not a valid function. Is that just a typo? I don't think the singular add_plugin has been a thing since version 0.10 (according to chatgpt 😅)

Screenshot 2024-10-03 at 11 27 33 AM

When I change it to ".add_plugins" I then see another error for the argument to this function:

Screenshot 2024-10-03 at 11 27 23 AM

Can we please update it to some code that works?

Or am I doing it wrong?

Thanks 👍

@JimLynchCodes JimLynchCodes added the bug Something isn't working label Oct 3, 2024
@SergioRibera
Copy link
Owner

Oooo, you are absolutely right, I will review this in detail, I should take the example out of the examples folder, for now I recommend you take those, thank you very much for the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants