Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CardPool desync: Disappearing cards #623

Open
Senryoku opened this issue Nov 29, 2023 · 3 comments
Open

CardPool desync: Disappearing cards #623

Senryoku opened this issue Nov 29, 2023 · 3 comments
Assignees
@Senryoku
Labels
bug Something isn't working frontend

Comments

@Senryoku
Copy link
Owner

Following #606

I have identified at least one other scenario:

  • Without letting go, drag & drop a card (1) to an other column and back to its original place. I don't think we are handling any events at this point, this is all sortablejs-vue3.
  • Remove the card above it (2), either by drag & drop or by click.
  • The DOM element of the card (1) is deleted. The card object is still present in the associated column (see card count on top of the column)

GIF 29-11-2023 01-21-44

I don't understand why this happens.
The issue is detectable though. As a first workaround I'll force a re-render of the component when a desync. is detected.
@Senryoku Senryoku added the bug Something isn't working label Nov 29, 2023
@Senryoku Senryoku self-assigned this Nov 29, 2023
Senryoku added a commit that referenced this issue Nov 29, 2023
@Senryoku
[Client] Yet another layer of protection against CardPool desync.
0092fdf 
This one re-renders the whole component when a desync is detected after a call to addToColumn or removeFromColumn.
Workaround for #623, this is not a proper fix. I still don't understand what's going on exactly.
@Senryoku
Copy link
Owner Author

Workaround in 0092fdf.

@Senryoku
Copy link
Owner Author

Somehow, this can still happen. See the case of the disappearing Palace Jailer here:
https://www.youtube.com/watch?v=iJ9HXRFfldU&t=719s

No luck reproducing it yet.

Senryoku added a commit that referenced this issue Mar 30, 2024
@Senryoku
[Client] Even heavier workaround for #623.
b3f0eac
@Senryoku
Copy link
Owner Author

Still no clue of what happened in the previous clip.
Hopefully b3f0eac will help recover from similar issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Senryoku Senryoku

Labels
bug Something isn't working frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Senryoku