Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiffGatherTask does not properly identify missing Diffs #4

Open
binfalse opened this issue Jul 12, 2017 · 1 comment · May be fixed by #5
Open

DiffGatherTask does not properly identify missing Diffs #4

binfalse opened this issue Jul 12, 2017 · 1 comment · May be fixed by #5

Comments

@binfalse
Copy link
Member

binfalse commented Jul 12, 2017 •
edited
Loading

Apparently, when triggering the /diff/service/trigger endpoint of https://github.com/SemsProject/masymos-diff-rest (some?) diffs are re-computed!? That is, there may be multiple DIFF nodes between two DOCUMENT nodes..

Especially annoying as #1 is unfixed..
@binfalse
Copy link
Member Author

There seems to be a mistake in

masymos-diff/src/main/java/de/unirostock/sems/masymos/diff/DiffGatherTask.java

Line 129 in 331678b

String query = "Match (a:DOCUMENT)-[:HAS_SUCCESSOR]->(b:DOCUMENT) Where NOT (a)-->(:DIFF)-->(b) and (a)-->(:MODEL) and (b)-->(:MODEL) Return a,b Limit {limit}";
(and the following queries)

The connections between DOCUMENT and DIFF is always DOCUMENT-[]->DIFF! The query, however, searches for

Where NOT (a)-->(:DIFF)-->(b)

while it should search for

Where NOT (a)-->(:DIFF)<--(b)

binfalse added a commit to binfalse/masymos-diff that referenced this issue Jul 12, 2017
@binfalse
fixing the query to gather missing diffs
fa07b7f 
fixes SemsProject#4
binfalse added a commit to binfalse/masymos-diff that referenced this issue Jul 12, 2017
@binfalse
fixing the query to gather missing diffs
ec720c6 
fixes SemsProject#4
@binfalse binfalse linked a pull request Jul 12, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixing the query to gather missing diffs binfalse/masymos-diff
1 participant
@binfalse