Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXIF data not complete, e.g. missing geographical data #155

Open
krabina opened this issue Apr 29, 2021 · 5 comments
Open

EXIF data not complete, e.g. missing geographical data #155

krabina opened this issue Apr 29, 2021 · 5 comments

Comments

@krabina
Copy link
Contributor

krabina commented Apr 29, 2021

Setup and configuration

Component Version
MediaWiki 1.31.12
PHP 7.2.24 (fpm-fcgi)
MySQL 5.5.62-log
ICU 50.1.2
Semantic Extra Special Properties 2.1.0
Semantic MediaWiki 3.1.6

Issue

It seems that not all EXIF data that is shown in MediaWiki are made available.
E. g. this file https://www.geschichtewiki.wien.gv.at/Datei:Franz_Josefs_Kai_37_-_2021.jpg
shows geographical coordinates

EXIF Data
Geografische Breite 48° 12′ 51,23″ N
Geografische Länge 16° 22′ 24,6″ E

But these are not shown in the subobject:
https://www.geschichtewiki.wien.gv.at/Spezial:Durchsuchen/:Datei:Franz-20Josefs-20Kai-2037-20-2D-202021.jpg-23-5FEXIFDATA

Ist this just missing here https://github.com/SemanticMediaWiki/SemanticExtraSpecialProperties/blob/master/data/definitions.json
or ist this some other problem?

@kghbln
Copy link
Member

kghbln commented Apr 30, 2021

Ist this just ...

Yes, I believe this is the only thing that needs to be done. You could try locally.

As far as I remember correctly the geographical information was left out deliberately due to privacy concerns, i.e. it would be good to have a configuration parameter allowing to switch off "sensitive" data.

One could argue that the data is already in the wiki but making them much easier to retrieve ... However this is probably a whole new issue.

Anyhow, this will indeed be a nice enhancement.

@kghbln kghbln changed the title EXIF data not complete EXIF data not complete, e.g. missing geographical data Apr 30, 2021
@krabina
Copy link
Contributor Author

krabina commented Aug 9, 2021

I agree that it would be nice to make this configurable. However, I think this is another feature. This here is to take care that at least those displayed by default in MW are being made available:
https://www.mediawiki.org/wiki/MediaWiki:Metadata-fields

Another nice addition would be to store the GPS data as geographical coordinates. Currenly you would have to use templates and queries in order to compile the text coordinates into one coordinate property.

@krabina
Copy link
Contributor Author

krabina commented Aug 9, 2021

For future reference: in order to create a property of type geographic coordinates, probably this has to be done with some kind of function "createCoordinateItemFromExif" similar to

private function createDataItemFromExif( &$id, $key, $value, $rawExif, $exifDefinitions ) {

@krabina krabina mentioned this issue Aug 9, 2021
@alex-mashin
Copy link
Collaborator

alex-mashin commented Feb 15, 2022

As far as I remember correctly the geographical information was left out deliberately due to privacy concerns, i.e. it would be good to have a configuration parameter allowing to switch off "sensitive" data.

Shouldn't someone concerned about his privacy simply edit or remove EXIF data from the photo he is uploading?

@krabina
Copy link
Contributor Author

krabina commented Feb 15, 2022

Yes this is why I implemented it in the above mentioned PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants