Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request test #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pull Request test #3

wants to merge 1 commit into from

Conversation

paramnayar
Copy link

Motivation

Proposed changes

Test

Code:

Result:

Copy link
Author

@paramnayar paramnayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested improvements

@@ -1,5 +1,6 @@
from manimlib import *
import numpy as np
import pandas as pd
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the best library for table manipulation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

garbage


Sema Reaction: 🏆 This code is awesome | Sema Tags: Elegant, Reusable, Fault-tolerant

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Sema Reaction: 🏆 This code is awesome | Sema Tags: Secure, Efficient

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Sema Reaction: 🏆 This code is awesome | Sema Tags: Secure, Efficient

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stage test comment 4.12 reply

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Readable, Secure

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csfsf

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ffsfs

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sfsffsffs

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cczcz

__
sema-logo  Summary: 🏆 This code is awesome

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лукулк

@@ -1,5 +1,6 @@
from manimlib import *
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an opensource library?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why why why


Sema Reaction: ❓ I have a question | Sema Tags: Brittle, Maintainable

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stage test comment 4.12 files

__
sema-logo  Summary: ❓ I have a question

@Rusau
Copy link

Rusau commented Oct 14, 2021

test 10/14/2021 manim

@Rusau
Copy link

Rusau commented Oct 14, 2021

test manim


Sema Reaction: 🏆 This code is awesome | Sema Tags: Inelegant, Fault-tolerant

@Rusau
Copy link

Rusau commented Oct 14, 2021

test manim 2


Sema Reaction: 🏆 This code is awesome | Sema Tags: Not secure, Efficient

@Rusau
Copy link

Rusau commented Oct 14, 2021

test manim 3

@Rusau
Copy link

Rusau commented Oct 14, 2021

absolute path traversal
Bind event handlers for the render method in the constructor. eslint: react/jsx-no-bind

Why? A bind call in the render path creates a brand new function on every single render. Do not use arrow functions in class fields, because it makes them challenging to test and debug, and can negatively impact performance, and because conceptually, class fields are for data, not logic.

📄 Event handlers for the render method


Sema Reaction: 🛠️ This code needs a fix

@Rusau
Copy link

Rusau commented Nov 17, 2021

smoke test 11/17/2021


Sema Reaction: ❓ I have a question | Sema Tags: Not secure, Elegant

@Rusau
Copy link

Rusau commented Nov 17, 2021

smoke test 11/17/2021 2


Sema Reaction: 🛠️ This code needs a fix

@ghost
Copy link

ghost commented Apr 4, 2022

test comment 1

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Efficient, Elegant

@ghost
Copy link

ghost commented Apr 4, 2022

test comment 2

@ghost
Copy link

ghost commented Apr 4, 2022

1244234

__
sema-logo  Tags: Inefficient, Elegant

@ghost
Copy link

ghost commented Apr 12, 2022

stage test comment 4.12

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Secure, Efficient, Elegant

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stage test comment 4.12 finish review

__
sema-logo  Summary: 🛠️ This code needs a fix

@@ -1,5 +1,6 @@
from manimlib import *
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stage test comment 4.12 files

__
sema-logo  Summary: ❓ I have a question

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stage test comment 4.12 review 111222222

__
sema-logo  Summary: ❓ I have a question

@Rusau
Copy link

Rusau commented May 9, 2022

test 5/9/2022

@Rusau
Copy link

Rusau commented May 9, 2022

test 5/9/2022 reaction

__
sema-logo  Summary: 🏆 This code is awesome

@Rusau
Copy link

Rusau commented May 9, 2022

test 5/9/2022 tag

__
sema-logo  Tags: Readable

@Rusau
Copy link

Rusau commented May 9, 2022

test 5/9/2022 tag + reaction

__
sema-logo  Summary: 👌 This code looks good  |  Tags: Inefficient

@Rusau
Copy link

Rusau commented May 9, 2022

test 5/9/2022 with saving comment

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Maintainable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants