Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a better link from the @action arguments and the input.json contents #54

Open
kariharju opened this issue Jun 13, 2024 · 0 comments
Labels
Action Server Issue related to Action Server (auto-add to roadmap) Bug Something isn't working

Comments

@kariharju
Copy link
Contributor

kariharju commented Jun 13, 2024

The problem is that there's currently no link from the @action arguments that the user has created in code to the input.json. What should happen is that the extension (prior to running an action) should get the proper metadata to collect the arguments so that it could do a pre-validation of the input_<action-name>.json.

Also, it should probably do code-analysis to verify that it's actually correct.

With this info, it should also be possible to get OAuth2 information from the action itself instead of requiring it to be entered as vscode:request:oauth2.

The original issue was:

VS Code asks the user to add input.json parameters for action that has no input arguments

The error is visible in VS Code extension, but I assume the validation logic comes from Action Server
Repro:

  1. Create new action in VS Code that has no input arguments
  2. Run the Action from the VS Code sidebar

Result: VS Code asks user to config input parameter in devdata/input.json.
Expected: No input args so query is misplaced

@kariharju kariharju added Action Server Issue related to Action Server (auto-add to roadmap) Bug Something isn't working labels Jun 13, 2024
@fabioz fabioz changed the title VS Code asks the user to add input.json parameters for action that has no input arguments There should be a better link from the @action arguments and the input.json contents that the user can edit Jul 16, 2024
@fabioz fabioz changed the title There should be a better link from the @action arguments and the input.json contents that the user can edit There should be a better link from the @action arguments and the input.json contents Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action Server Issue related to Action Server (auto-add to roadmap) Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant