Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement full page screenshot for Chrome #8705

Closed
k7z45 opened this issue Sep 16, 2020 · 4 comments
Closed

Implement full page screenshot for Chrome #8705

k7z45 opened this issue Sep 16, 2020 · 4 comments

Comments

@k7z45
Copy link
Contributor

k7z45 commented Sep 16, 2020

🚀 Feature Proposal

ChromeDriver implemented full page screenshot end point similar to geckodriver in ChromeDriver 86.0.4240.22 CL (https://chromium-review.googlesource.com/c/chromium/src/+/2300980).
Selenium can utilize the endpoint to implement full page screenshot feature.

There is a proposal at w3c/webdriver#1536 for adding it to WebDriver standards.
Since gecko already supports it, I think we can add it for Chrome as well.

Motivation

Highly sought after in https://bugs.chromium.org/p/chromedriver/issues/detail?id=294#c161.

Example

The ChromeDriver endpoint is Get request at /session/:sessionId/screenshot/full

@ghost ghost added the needs-triaging label Sep 16, 2020
@diemol
Copy link
Member

diemol commented Sep 20, 2020

@k7z45 this is part of #8168, I will close this as a duplicate.

@diemol diemol closed this as completed Sep 20, 2020
@k7z45
Copy link
Contributor Author

k7z45 commented Sep 21, 2020

@diemol BiDi should not be a dependency for this feature. Firefox already implements this feature. ChromeDriver can now supports full page screenshot through endpoint /session/:sessionId/screenshot/full in version 86. It can be available to user if Selenium makes use of it.

@diemol
Copy link
Member

diemol commented Sep 21, 2020

The linked issue is not about implementing BiDi, is about defining an API, that initially works with CDP (which is the work being done for Selenium 4).

@k7z45
Copy link
Contributor Author

k7z45 commented Sep 21, 2020

Agh, gotcha. Thanks for the clarification!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants