Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

Use a single variable to mark pLS not to be included in TCs #331

Open
VourMa opened this issue Oct 3, 2023 · 0 comments
Open

Use a single variable to mark pLS not to be included in TCs #331

VourMa opened this issue Oct 3, 2023 · 0 comments
Labels
code cleanup enhancement New feature or request

Comments

@VourMa
Copy link
Contributor

VourMa commented Oct 3, 2023

It is confusing that in the second pass of the checkHitspLS kernel, as well as in the crossCleanpLS kernel, the triplet and duplicate pLSs are skipped from the checks (for no obvious reason at this stage). This happens because they are in any case not considered for addition to the TCs and, therefore, we don't want to waste time checking something that we are going to drop later in any case.

This coding choice may make sense performance-wise but causes extra difficulties when changing the characteristics of the pLSs to be added in the TCs. For example, to include properly cleaned triplet pLSs in the TCs, one needs to change the same line in 3 (if not more) places.

To facilitate such changes, as well as making the code clearer, it was proposed to add a new variable (or overloading the isDup variable) that is set in one place and marks the pLSs to be skipped from addition to the TCs.

@VourMa VourMa added enhancement New feature or request code cleanup labels Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
code cleanup enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant