Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error reading Compact SeedQR generated by SeedSigner itself. #656

Open
felipetdsa opened this issue Jan 2, 2025 · 1 comment · May be fixed by #657
Open

Error reading Compact SeedQR generated by SeedSigner itself. #656

felipetdsa opened this issue Jan 2, 2025 · 1 comment · May be fixed by #657

Comments

@felipetdsa
Copy link

felipetdsa commented Jan 2, 2025 •
edited
Loading

Entered the following 12 word seedphrase: abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about.
Got this Compact SeedQR:
qr_bandon
When I tried to scan this Compact SeedQR I got a message of invalid Qr Code.
Error occurs on versions 0.8.0 and 0.8.5-rc1. Didn't test older versions.
@kdmukai kdmukai linked a pull request Jan 3, 2025 that will close this issue
Open
6 tasks
@kdmukai
Copy link
Contributor

kdmukai commented Jan 3, 2025

To facilitate testing, here's a clean copy of the above Compact SeedQR. #657 has additional SeedQRs to test the fix.

abandon_11x_about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bugfix] DecodeQR: handle Compact SeedQR byte data that can be decoded to str kdmukai/seedsigner
2 participants
@kdmukai @felipetdsa