[Screen Redesign] Light rearrangement of SeedAddressVerificationSuccess #651
Conversation
|
Recording that in my review of this pr yesterday, that I'd found that the ui required two button-presses of "OK" instead of just one, and that I reported this directly to Keith for confirmation that he saw it too. At first, it felt like a "buggy" hardware button at my end. Since this morning, confirmed by the fact that I couldn't find anything in this pr that explicitely causes this bug, Keith has worked on changes to hardware buttons that simplifies and corrects this error for me... So awaiting a pr that might precede this one (even though they're separate issues). Beyond that, this new screen and pr works for me, it will have my tested ACK as soon as the underlying buttons issue is resolved. I am able to provoke the same strange behavior outside of this pr, in 'dev' at the 0.8.5-rc1 commit it happens as well. Picking a higher address index than a lower one will provoke this (not the 3rd address, pick the 93rd address to scan instead). Also, clicking quickly instead of waiting helps to avoid this "press OK again" behavior. |
Description
Fixes #650
Removes the sentence that had complex variable insertions in favor of simple single line reporting.
Before / After
Due to the slight UI changes, the master
messages.pottranslation strings have changed slightly and will need new translations.Additional light refactors:
LargeIconStatusScreenbody text component if notextinput param is provided. This allows this PR to simply referenceself.components[-1]to reference the the last VISIBLE display element; in this case, theLargeIconStatusScreen.status_headline.This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: