Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt new style guideline for capitalization: "Title Case" titles vs "Sentence case" buttons #648

Open
kdmukai opened this issue Dec 29, 2024 · 1 comment

Comments

@kdmukai
Copy link
Contributor

kdmukai commented Dec 29, 2024

TopNav titles should be "Title Case" where every major word (and, for now, every minor word, too) should be capitalized.

LoadSeedView (5)

Only aware of one English screen that needs to be fixed: https://github.com/SeedSigner/seedsigner-screenshots/blob/dev/en/seed_views/SeedAddPassphraseExitDialogView.png


But buttons should be "Sentence case": only the the first word is capitalized (though proper nouns like "SeedQR" should always retain their capitalization).

There are many buttons that need capitalization fixes.


Some proper noun judgment calls:

  • "Xpub" always capitalized? I vote no.
  • "BIP-39 Passphrase"? Probably yes because it's such an important topic to get right.
  • "Native Segwit" / "Nested Segwit" / "Taproot"? Yes? They are crucial concepts, even if they're not always capitalized elsewhere in the bitcoin world.
  • "Custom derivation"? No need to always capitalize.

related: SeedSigner/seedsigner-translations#8

@jdlcdl
Copy link

jdlcdl commented Dec 30, 2024

Yes, YES, 100%!

Guidelines that are strict and implemented in English will also be picked up by detail-oriented translators where applicable. While I don't understand Spanish, I'm picking-up that this is getting discussed in that tg group too. It's helpful as I'll make similar suggestions in French.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants