Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create financial reports guide #1091

Closed
wants to merge 3 commits into from

Conversation

zkhin
Copy link
Contributor

@zkhin zkhin commented Feb 22, 2022

Fixes #1088

┆Issue is synchronized with this Monday item by Unito
┆Link To Item: https://seed-company-squad.monday.com/boards/3451697530/pulses/3466506086

@zkhin zkhin requested a review from CarsonF as a code owner February 22, 2022 10:17
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing it in the UI now, I don't think this gives enough context.
Screen Shot 2022-02-22 at 8 44 31 AM

The new button just seems out of place, since there's no info to describe why it's there.
Also, both the main card action area & the view reports button make up the primary action of this card - to go to the reports list. But this doesn't add any value as the list will be empty.

I think instead we should remove all of the card actions and the card body under the title, with a check list. Maybe with some copy too that says something like, "complete these requirements to access financial reports".

I just tried to mock up something, and I think that puts too much info on this card.
Let's just add some copy to the card & remove the card actions, and then put dependency details on the report list page.
Something like this:
Screen Shot 2022-02-22 at 9 24 33 AM
Screen Shot 2022-02-22 at 9 25 01 AM

@zkhin
Copy link
Contributor Author

zkhin commented Feb 25, 2022

Here are updated UI screenshots.
image
image
image

@zkhin zkhin requested a review from CarsonF February 25, 2022 19:56
@zkhin zkhin requested a review from CarsonF February 28, 2022 13:54
@sethmcknight
Copy link
Member

This lived to the end of its lifetime and died

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guide to create financial reports
3 participants