Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add product placeholder field #1093

Closed
wants to merge 1 commit into from
Closed

Add product placeholder field #1093

wants to merge 1 commit into from

Conversation

zkhin
Copy link
Contributor

@zkhin zkhin commented Mar 7, 2022 •
edited by sync-by-unito bot
Loading

Fixes #1055

UI

image
image

┆Issue is synchronized with this Monday item by Unito
┆Link To Item: https://seed-company-squad.monday.com/boards/3451697530/pulses/3466505085

@zkhin zkhin requested a review from CarsonF as a code owner March 7, 2022 20:23
@zkhin
Copy link
Contributor Author

zkhin commented Mar 7, 2022

@CarsonF

When using this field all other required fields, should not be required.

I checked the createOtherProduct mutation and the title field is required on the API side. How can we avoid this required field when using placeholderDescription

@zkhin zkhin force-pushed the feature/1055-product-placeholder-field branch from 68483b2 to f927258 Compare March 17, 2022 18:19
@sethmcknight
Copy link
Member

This lived to the end of its lifetime and died

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarsonF CarsonF Awaiting requested review from CarsonF CarsonF is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Product Placeholder Field
2 participants
@zkhin @sethmcknight