-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] PlugIn should wrap error to native HomeAssistant error to support 'continue_on_error' #559
Comments
I’ve run into this too. It causes problems when the failure is minor and non fatal, and the automation then fails to run the next step in a sequence that may be a very critical important step. So, I’m agreeing this is an important improvement. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Voting for this to be kept open... |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue was closed because it has been stalled for 5 days with no activity. |
Can we unstale ? |
I’ll reopen, it would be a nice improvement. Can’t say anyone will get to it anytime soon but it’s worth keeping as a a feature request/enhancement IMHO. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
unstale |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Stayin Alive stayin alive |
@SecKatie can we get this issue addressed? |
It shouldn't close now that it has the correct tag |
Changing tag to enhancement to avoid the stale-bot. |
Describe the bug
Without being able to dive into the code, I'm making a bit of an assumption here.
I'm assuming that this plugin throws a generic error (vs a HomeAssistant specific error) when something isnt as expected.
HomeAssistant continue_on_error only handles HomeAsssistant specific errors. Sample discussion and 2.
So if any error happens (which can be a separate report, I seem to sometime get an error even though an action was successful), currently the whole script stops instead of being able to be 'caught' by HomeAssistant and continuing.
Sample error:
### (There is currently workaround by calling scripts via script.turn_on)
The text was updated successfully, but these errors were encountered: