Merge pull request #164 from SeasideSt/slime-pharo12-fixes

Slime pharo12 fixes

repository/BaselineOfGrease.package/.filetree

@@ -1,4 +1,5 @@
 {
-	"noMethodMetaData" : true,
 	"separateMethodMetaAndSource" : false,
-	"useCypressPropertiesFile" : true }
+	"noMethodMetaData" : true,
+	"useCypressPropertiesFile" : true
+}

repository/BaselineOfGrease.package/BaselineOfGrease.class/instance/baselineSqueak..st

@@ -22,14 +22,7 @@ baselineSqueak: spec
 				package: 'Grease-Tests-Squeak-Core'
 					with: [ spec requires: #('Grease-Tests-Core') ];
 				package: 'Grease-Tests-Squeak5-Core'
-					with: [ spec requires: #('Grease-Tests-Squeak-Core') ];
-				package: 'Grease-Slime'
-					with: [ spec requires: #('Refactoring-Core' 'Grease-Core') ];
-				package: 'Grease-Tests-Slime'
-					with: [ spec requires: #('Grease-Slime') ].
-			spec
-				group: 'Slime' with: #('Grease-Slime');
-				group: 'Slime Tests' with: #('Grease-Tests-Slime') ].
+					with: [ spec requires: #('Grease-Tests-Squeak-Core') ] ].
 	spec
 		for: #(#'squeak6.x')
 		do: [
@@ -52,11 +45,4 @@ baselineSqueak: spec
 				package: 'Grease-Tests-Squeak-Core'
 					with: [ spec requires: #('Grease-Tests-Core') ];
 				package: 'Grease-Tests-Squeak6-Core'
-					with: [ spec requires: #('Grease-Tests-Squeak-Core') ];
-				package: 'Grease-Slime' 
-					with: [ spec requires: #('Refactoring-Core' 'Grease-Core') ];
-				package: 'Grease-Tests-Slime'
-					with: [ spec requires: #('Grease-Slime') ].
-			spec
-				group: 'Slime' with: #('Grease-Slime');
-				group: 'Slime Tests' with: #('Grease-Tests-Slime') ]
+					with: [ spec requires: #('Grease-Tests-Squeak-Core') ] ]

repository/BaselineOfGrease.package/BaselineOfGrease.class/properties.json

@@ -1,14 +1,11 @@
 {
-	"category" : "BaselineOfGrease",
-	"classinstvars" : [
-		 ],
-	"classvars" : [
-		 ],
 	"commentStamp" : "",
-	"instvars" : [
-		 ],
-	"name" : "BaselineOfGrease",
-	"pools" : [
-		 ],
 	"super" : "BaselineOf",
-	"type" : "normal" }
+	"category" : "BaselineOfGrease",
+	"classinstvars" : [ ],
+	"pools" : [ ],
+	"classvars" : [ ],
+	"instvars" : [ ],
+	"name" : "BaselineOfGrease",
+	"type" : "normal"
+}

repository/BaselineOfGrease.package/monticello.meta/categories.st

@@ -1,2 +1 @@
-SystemOrganization addCategory: #BaselineOfGrease!
-SystemOrganization addCategory: #'BaselineOfGrease-Manifest'!
+self packageOrganizer ensurePackage: #BaselineOfGrease withTags: #('Manifest')!

repository/BaselineOfGrease.package/properties.json

@@ -1,2 +1 @@
-{
-	 }
+{ }

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/compile.in..st

@@ -1,3 +1,7 @@
 accessing-code
 compile: aString in: aClass
-	^ aClass compile: aString classified: #(accessing)
+
+	GRPlatform current
+		compile: aString
+		into: aClass
+		classified: #accessing

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/defineClass.superclass..st

@@ -1,13 +1,4 @@
 accessing-code
 defineClass: aClassSymbol superclass: aSuperSymbol
-	| class |
-	model defineClass: aSuperSymbol , ' subclass: #' , aClassSymbol , '
-		instanceVariableNames: '''' 
-		classVariableNames: ''''
-		poolDictionaries: ''''
-		category: ''' , self category , ''''.
-	class := model classNamed: aClassSymbol.
-	environment 
-		addClass: class;
-		addClass: class theMetaClass.
-	^ class
+	"For compatibility"
+	^ self defineSubClassOf: aSuperSymbol

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/defineSubClassOf..st

@@ -0,0 +1,20 @@
+accessing-code
+defineSubClassOf: aSuperSymbol
+
+	| class |
+	class := SystemVersion current major >= 12
+		         ifTrue: [
+			         factory make: [ :aBuilder |
+				         aBuilder
+					         superclass: (Smalltalk at: aSuperSymbol);
+					         package: self category ] ]
+		         ifFalse: [
+			         factory
+				         newSubclassOf: (Smalltalk at: aSuperSymbol)
+				         instanceVariableNames: ''
+				         classVariableNames: 'classVarsString'
+				         category: self category ].
+	environment
+		addClass: class;
+		addClass: class theMetaClass.
+	^ class

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/setUp.st

@@ -1,5 +1,6 @@
 running
 setUp
 	super setUp.
+	factory := ClassFactoryForTestCase new.
 	model := RBNamespace new.
 	environment := RBClassEnvironment new

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/tearDown.st

@@ -1,7 +1,5 @@
 running
 tearDown
+
 	super tearDown.
-	(Smalltalk organization listAtCategoryNamed: self category) do:[ :e | 
-		SmalltalkImage current removeClassNamed: e ].
-	Smalltalk organization
-		removeCategory: self category
+	factory cleanUp

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testAnsiBooleansRule.st

@@ -1,9 +1,7 @@
 tests-transform
 testAnsiBooleansRule
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile: 'and 1 and: [ 2 ] and: [ 3 ] and: [ 4 ]' in: class.
 	self compile: 'or 1 or: [ 2 ] or: [ 3 ] or: [ 4 ]' in: class.
 	self 

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testAnsiCharacterRule.st

@@ -1,9 +1,7 @@
 tests-transform
 testAnsiCharacterRule
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile: 'character Character value: 123' in: class.
 	self compile: 'characterRange $a to: $c' in: class.
 	self 

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testAnsiCollectionsRule.st

@@ -1,9 +1,7 @@
 tests-transform
 testAnsiCollectionsRule
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile: 'withIndexDo #() withIndexDo: [ :each :index | each + index ]' in: class.
 	self compile: 'doWithIndex #() doWithIndex: [ :each :index | each + index ]' in: class.
 	self compile: 'collectThenDo #() collect: [ :a | a ] thenDo: [ :b | b ]' in: class.

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testAnsiConditionalsRule.st

@@ -1,9 +1,7 @@
 tests-transform
 testAnsiConditionalsRule
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile: 'ifNotNil 1 ifNotNil: [ | a | self or. self and ]' in: class.
 	self compile: 'ifNotNilDo 1 ifNotNilDo: [ :a | ^ a ]' in: class.
 	self 

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testAnsiConvertorRule.st

@@ -1,9 +1,7 @@
 tests-transform
 testAnsiConvertorRule
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile: 'convertInteger ''1'' asInteger' in: class.
 	self compile: 'convertString 2 asString' in: class.
 	self 

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testAnsiExceptionsRule.st

@@ -1,9 +1,7 @@
 tests-transform
 testAnsiExceptionsRule
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile: 'exception1 [ self or ] on: Error do: [ self or ]' in: class.
 	self compile: 'exception2 [ self or ] on: Error do: [ self or. self or ]' in: class.
 	self compile: 'exception3 [ self or ] on: Error do: [ | a | a := 0 ]' in: class.

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testAnsiStreamsRule.st

@@ -1,9 +1,7 @@
 tests-transform
 testAnsiStreamsRule
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile: 'writeStream ^ '''' writeStream' in: class.
 	self compile: 'writeCr | stream | stream := WriteStream on: ''''. stream cr. stream nextPut: Character cr' in: class.
 	self compile: 'writeLf | stream | stream := WriteStream on: ''''. stream lf. stream nextPut: Character lf' in: class.

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testAnsiStringsRule.st

@@ -1,9 +1,7 @@
 tests-transform
 testAnsiStringsRule
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile: 'stringCr String cr, (String with: Character cr)' in: class.
 	self compile: 'stringTab String tab, (String with: Character tab)' in: class.
 	self compile: 'stringLf String lf, (String with: Character lf)' in: class.

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testBasicNewInitializeMissing.st

@@ -1,9 +1,7 @@
 tests-block
 testBasicNewInitializeMissing
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #Object.
+	class := self defineSubClassOf: #Object.
 	self compile:  'initialize' in: class.
 	self
 		runRule: GRBasicNewInitializeMissingRule

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testBlockFormatting.st

@@ -1,30 +1,28 @@
 tests-parsetree
 testBlockFormatting
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
-	class
+	class := self defineSubClassOf: #GRObject.
+	self 
 		compile: 'invalid1
 			[:a ]'
-		classified: #(accessing).
-	class
+		in: class.
+	self
 		compile: 'invalid2
 			[:a | ]'
-		classified: #(accessing).
-	class
+		in: class.
+	self
 		compile: 'invalid3
 			[ :b]'
-		classified: #(accessing).
+		in: class.
 
-	class
+	self
 		compile: 'invalid4
 			[ :a| ]'
-		classified: #(accessing).
-	class
+		in: class.
+	self
 		compile: 'invalid5
 			[ :a |a ]'
-		classified: #(accessing).
+		in: class.
 	self 
 		runRule: GRBlockFormattingRule
 		selectors: #(invalid1 invalid2 invalid3 invalid4 invalid5)

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testDeprecatedApiProtocol.st

@@ -1,11 +1,9 @@
 tests-block
 testDeprecatedApiProtocol
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
-	self compile: 'deprecated1 self greaseDeprecatedApi: ''GRSlimeMockObject>>#deprecated1'' details: ''Something.''' in: class.
-	self compile: 'deprecated2 self greaseDeprecatedApi: ''GRSlimeMockObject>>#deprecated'' details: ''Something.''' in: class.
+	class := self defineSubClassOf: #GRObject.
+	self compile: 'deprecated1 self greaseDeprecatedApi: ''',class name,'>>#deprecated1'' details: ''Something.''' in: class.
+	self compile: 'deprecated2 self greaseDeprecatedApi: ''',class name,'>>#deprecated'' details: ''Something.''' in: class.
 	self compile: 'deprecated3 self greaseDeprecatedApi: ''GRSlimeMock>>#deprecated3'' details: ''Something.''' in: class.
 	self 
 		runRule: GRDeprecatedApiProtocolRule

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testEmptyStatements.st

@@ -1,9 +1,7 @@
 tests-block
 testEmptyStatements
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile: 'emptyStatement1. self and' in: class.
 	self compile: 'emptyStatement2 self and..' in: class.
 	self compile: 'emptyStatement3 self and."foo".' in: class.

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testInvalidObjectInitialization.st

@@ -1,9 +1,7 @@
 tests-block
 testInvalidObjectInitialization
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile:  'initializeFoo: aNumber' in: class.
 	self 
 		runRule: GRInvalidObjectInitializationRule

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testNonPortableMessageRule.st

@@ -1,9 +1,7 @@
 tests-block
 testNonPortableMessageRule
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 
 	self compile: 'invalid1 ^ Array new anyOne' in: class.
 	self compile: 'valid1 ^ Array new first' in: class.

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testNonPortableSourceFormat.st

@@ -1,9 +1,7 @@
 tests-block
 testNonPortableSourceFormat
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile: 'invalid ^ ''Unicode snow man', (String with: (Character codePoint: 16r2603)) , '''' in: class.
 	self compile: 'valid ^ ''everything is fine''' in: class.
 	self 

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testNotPortableCollectionsRule.st

@@ -1,9 +1,7 @@
 tests-transform
 testNotPortableCollectionsRule
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile: 'beginsWith1 ''abc'' beginsWith: ''a''' in: class.
 	self compile: 'endsWith1 ''abc'' endsWith: ''a''' in: class.
 	self 

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testObjectIn.st

@@ -1,9 +1,7 @@
 tests-transform
 testObjectIn
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
+	class := self defineSubClassOf: #GRObject.
 	self compile: 'objectIn1 1 in: [ :val | val factorial ]' in: class.
 	self compile: 'objectIn2 2 in: [ :val | | temps | val factorial ]' in: class.
 	self compile: 'objectIn3 2 in: [ ''not this'' ]' in: class.

repository/Grease-Tests-Slime.package/GRSlimeTest.class/instance/testParensFormatting.st

@@ -1,17 +1,15 @@
 tests-parsetree
 testParensFormatting
 	| class |
-	class := self
-		defineClass: #GRSlimeMockObject
-		superclass: #GRObject.
-	class
+	class := self defineSubClassOf: #GRObject.
+	self
 		compile: 'invalid1
 			( 1 + 2)'
-		classified: #(accessing).
-	class
+		in: class.
+	self
 		compile: 'invalid2
 			(1 + 2 )'
-		classified: #(accessing).
+		in: class.
 	self 
 		runRule: GRParensFormattingRule
 		selectors: #(invalid1 invalid2)