Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor datetimepicker #60

Open
spbnick opened this issue Oct 17, 2017 · 2 comments
Open

Refactor datetimepicker #60

spbnick opened this issue Oct 17, 2017 · 2 comments
Labels
pri: low
Milestone
First release

Comments

@spbnick
Copy link
Member

spbnick commented Oct 17, 2017

The datetimepicker class and its use need to be refactored. In particular:

  • The class user shouldn't care about parsing what component provides
  • The class user shouldn't have to keep the last correctly-parsed date and should always receive both the last parsed date and the current text input from the component
@spbnick spbnick added this to the First release milestone Oct 17, 2017
@spbnick
Copy link
Member Author

spbnick commented Oct 20, 2017

Perhaps also put it into a separate module.

@sabbaka
Copy link

sabbaka commented Jan 5, 2018

https://reactdatepicker.com/ you may review "Select Time" example, maybe it's a good fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pri: low
Projects
None yet
Milestone
First release
Development

No branches or pull requests
2 participants
@spbnick @sabbaka