Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loudly adverb. #72

Open
perrygoy opened this issue Mar 31, 2023 · 2 comments
Open

Add Loudly adverb. #72

perrygoy opened this issue Mar 31, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@perrygoy
Copy link
Member

Since we're adding Quietly in #71, let's add Loudly to do the exact opposite!

Say you've got a complicated Task that does like, twelve other Tasks. You normally don't want those other Tasks logged, so you wrap them in a Quietly so the top-Task can summarize what they're doing. But during one of the sub-sub-sub-Tasks, you enter a string into an input field that you really need to know to debug when the test goes wrong.

Enter text loudly with Loudly! Loudly will make sure that no matter whether a Quietly on the outside told the Narrator to be quiet, or a Quietly inside of it tries to stop narrating, everything it's passed will be narrated. LOUDLY!

@perrygoy perrygoy self-assigned this Mar 31, 2023
@perrygoy perrygoy added the enhancement New feature or request label Mar 31, 2023
@perrygoy
Copy link
Member Author

This one will probably need a new Narrator method that skips any kinks.

@bandophahita
Copy link
Contributor

bandophahita commented Jul 18, 2023

I think skipping kinks would completely nullify how Eventually works. We depend on the kinking to toss away the repeated loops in Eventually. If someone wrapped Loudly around actions that use Eventually the logging would look pretty atrocious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants