Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many options to close the same modal #786

Closed
dhinrichs-scottlogic opened this issue Jan 19, 2024 · 2 comments
Closed

Too many options to close the same modal #786

dhinrichs-scottlogic opened this issue Jan 19, 2024 · 2 comments
Labels
enhancement New feature or request frontend Requires work on the frontend triage New tickets to be checked by the maintainers

Comments

@dhinrichs-scottlogic
Copy link
Contributor

Feature Request

Description

Many of our modals can be dismissed with the close button at the top right, as well as an "Okay" or "Cancel" button.
It can be confusing to have multiple ways to dismiss the same modal, so this needs to be redesigned

@dhinrichs-scottlogic dhinrichs-scottlogic added enhancement New feature or request triage New tickets to be checked by the maintainers labels Jan 19, 2024
@chriswilty
Copy link
Member

@dhinrichs-scottlogic Can this go into one of your milestones, so we don't lose track of it?

@chriswilty chriswilty added the frontend Requires work on the frontend label Jan 25, 2024
@chriswilty
Copy link
Member

Will not fix, as this is almost redundant following the multi-page modal redesign (#578). The "reset" modals still have two close buttons, but it's open to debate whether or not it's a bad thing. As it stands, all story modals have the same look'n'feel so it feels worse to remove the top-right close button for just these two modals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Requires work on the frontend triage New tickets to be checked by the maintainers
Projects
None yet
Development

No branches or pull requests

2 participants