Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS linting #732

Closed
gsproston-scottlogic opened this issue Jan 3, 2024 · 0 comments · Fixed by #738
Closed

Add CSS linting #732

gsproston-scottlogic opened this issue Jan 3, 2024 · 0 comments · Fixed by #738
Assignees
Labels
enhancement New feature or request frontend Requires work on the frontend good first issue Simple issue refactor Improve code quality

Comments

@gsproston-scottlogic
Copy link
Contributor

Feature Request

Description

Add linting rules for CSS styling/formatting. We can use Stylelint for this.

Additional context

From discussions in a PR, it would be nice to have some styling/formatting rules for our CSS files.
Stylelint contains two rules (here and here) which cover what is mentioned in the PR, but they are both included in the standard config, so just include that.

So, add the Stylelint standard config to the linting script, meaning CSS files should be linted when doing npm run lint on the frontend.
Once that's added, run the linter and fix any issues.

Acceptance criteria

Just formatting/styling changes, so regression testing here.

@gsproston-scottlogic gsproston-scottlogic added enhancement New feature or request frontend Requires work on the frontend refactor Improve code quality good first issue Simple issue triage New tickets to be checked by the maintainers and removed triage New tickets to be checked by the maintainers labels Jan 3, 2024
@gsproston-scottlogic gsproston-scottlogic self-assigned this Jan 3, 2024
@gsproston-scottlogic gsproston-scottlogic linked a pull request Jan 3, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Requires work on the frontend good first issue Simple issue refactor Improve code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant